* [PATCH] net: am79c961a: Omit private ndo_get_stats function
@ 2010-12-02 17:20 Tobias Klauser
2010-12-03 15:40 ` Russell King - ARM Linux
0 siblings, 1 reply; 3+ messages in thread
From: Tobias Klauser @ 2010-12-02 17:20 UTC (permalink / raw)
To: Russell King, David S. Miller, netdev
am79c961_getstats() just returns dev->stats so we can leave it out
alltogether and let dev_get_stats() do the job.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
drivers/net/arm/am79c961a.c | 9 ---------
1 files changed, 0 insertions(+), 9 deletions(-)
diff --git a/drivers/net/arm/am79c961a.c b/drivers/net/arm/am79c961a.c
index 62f2110..0c9217f 100644
--- a/drivers/net/arm/am79c961a.c
+++ b/drivers/net/arm/am79c961a.c
@@ -340,14 +340,6 @@ am79c961_close(struct net_device *dev)
return 0;
}
-/*
- * Get the current statistics.
- */
-static struct net_device_stats *am79c961_getstats (struct net_device *dev)
-{
- return &dev->stats;
-}
-
static void am79c961_mc_hash(char *addr, unsigned short *hash)
{
if (addr[0] & 0x01) {
@@ -665,7 +657,6 @@ static const struct net_device_ops am79c961_netdev_ops = {
.ndo_open = am79c961_open,
.ndo_stop = am79c961_close,
.ndo_start_xmit = am79c961_sendpacket,
- .ndo_get_stats = am79c961_getstats,
.ndo_set_multicast_list = am79c961_setmulticastlist,
.ndo_tx_timeout = am79c961_timeout,
.ndo_validate_addr = eth_validate_addr,
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] net: am79c961a: Omit private ndo_get_stats function
2010-12-02 17:20 [PATCH] net: am79c961a: Omit private ndo_get_stats function Tobias Klauser
@ 2010-12-03 15:40 ` Russell King - ARM Linux
2010-12-06 21:25 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Russell King - ARM Linux @ 2010-12-03 15:40 UTC (permalink / raw)
To: Tobias Klauser; +Cc: David S. Miller, netdev
On Thu, Dec 02, 2010 at 06:20:05PM +0100, Tobias Klauser wrote:
> am79c961_getstats() just returns dev->stats so we can leave it out
> alltogether and let dev_get_stats() do the job.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
> ---
> drivers/net/arm/am79c961a.c | 9 ---------
> 1 files changed, 0 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/net/arm/am79c961a.c b/drivers/net/arm/am79c961a.c
> index 62f2110..0c9217f 100644
> --- a/drivers/net/arm/am79c961a.c
> +++ b/drivers/net/arm/am79c961a.c
> @@ -340,14 +340,6 @@ am79c961_close(struct net_device *dev)
> return 0;
> }
>
> -/*
> - * Get the current statistics.
> - */
> -static struct net_device_stats *am79c961_getstats (struct net_device *dev)
> -{
> - return &dev->stats;
> -}
> -
> static void am79c961_mc_hash(char *addr, unsigned short *hash)
> {
> if (addr[0] & 0x01) {
> @@ -665,7 +657,6 @@ static const struct net_device_ops am79c961_netdev_ops = {
> .ndo_open = am79c961_open,
> .ndo_stop = am79c961_close,
> .ndo_start_xmit = am79c961_sendpacket,
> - .ndo_get_stats = am79c961_getstats,
> .ndo_set_multicast_list = am79c961_setmulticastlist,
> .ndo_tx_timeout = am79c961_timeout,
> .ndo_validate_addr = eth_validate_addr,
> --
> 1.7.0.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] net: am79c961a: Omit private ndo_get_stats function
2010-12-03 15:40 ` Russell King - ARM Linux
@ 2010-12-06 21:25 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2010-12-06 21:25 UTC (permalink / raw)
To: linux; +Cc: tklauser, netdev
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
Date: Fri, 3 Dec 2010 15:40:57 +0000
> On Thu, Dec 02, 2010 at 06:20:05PM +0100, Tobias Klauser wrote:
>> am79c961_getstats() just returns dev->stats so we can leave it out
>> alltogether and let dev_get_stats() do the job.
>>
>> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
>
> Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-12-06 21:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-02 17:20 [PATCH] net: am79c961a: Omit private ndo_get_stats function Tobias Klauser
2010-12-03 15:40 ` Russell King - ARM Linux
2010-12-06 21:25 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).