From: Stephen Hemminger <shemminger@vyatta.com>
To: Breno Leitao <leitao@linux.vnet.ibm.com>,
Olof Johansson <olof@lixom.net>,
Eli Cohen <eli@dev.mellanox.co.il>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: [RFC] mark devices with broken LRO implementation
Date: Mon, 6 Dec 2010 09:10:10 -0800 [thread overview]
Message-ID: <20101206091010.036cd78b@nehalam> (raw)
In-Reply-To: <4CFD15F6.7040609@linux.vnet.ibm.com>
The kernel uses dev_disable_lro to disable Large Receive Offload
for cases where it is inappropriate. But several drivers do not implement
the required hook. This is a "penalty box" patch to encourage those
drivers to add support for the necessary ethtool set_flags.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
---
I only found three drivers that are broken. Normally, I would just fix
them; but since changing state in the device is hardware specific, and
I don't have the hardware or specs to do anything useful to fix it.
--- a/drivers/net/Kconfig 2010-12-06 08:52:30.376926696 -0800
+++ b/drivers/net/Kconfig 2010-12-06 09:02:02.013224592 -0800
@@ -28,6 +28,13 @@ menuconfig NETDEVICES
# that for each of the symbols.
if NETDEVICES
+config BROKEN_LRO
+ bool
+ ---help---
+ Allow drivers with partial Large Receive Offload support. These drivers
+ do not implement the necessary feature of disabling LRO support via
+ the ethtool set_flags operation.
+
config IFB
tristate "Intermediate Functional Block support"
depends on NET_CLS_ACT
@@ -2675,7 +2682,7 @@ config CHELSIO_T4VF
config EHEA
tristate "eHEA Ethernet support"
- depends on IBMEBUS && INET && SPARSEMEM
+ depends on IBMEBUS && INET && SPARSEMEM && BROKEN_LRO
select INET_LRO
---help---
This driver supports the IBM pSeries eHEA ethernet adapter.
@@ -2848,7 +2855,7 @@ config NIU
config PASEMI_MAC
tristate "PA Semi 1/10Gbit MAC"
- depends on PPC_PASEMI && PCI && INET
+ depends on PPC_PASEMI && PCI && INET && BROKEN_LRO
select PHYLIB
select INET_LRO
help
@@ -2857,7 +2864,7 @@ config PASEMI_MAC
config MLX4_EN
tristate "Mellanox Technologies 10Gbit Ethernet support"
- depends on PCI && INET
+ depends on PCI && INET && BROKEN_LRO
select MLX4_CORE
select INET_LRO
help
next prev parent reply other threads:[~2010-12-06 17:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-06 16:39 [PATCH] ehea: add the correct LRO status at dev->features leitao
2010-12-06 16:48 ` Stephen Hemminger
2010-12-06 16:57 ` Breno Leitao
2010-12-06 17:10 ` Stephen Hemminger [this message]
2010-12-06 17:18 ` [RFC] mark devices with broken LRO implementation Olof Johansson
2010-12-06 17:28 ` David Miller
2010-12-06 17:58 ` Stephen Hemminger
2010-12-06 17:33 ` [PATCH] ehea: add the correct LRO status at dev->features David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101206091010.036cd78b@nehalam \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=eli@dev.mellanox.co.il \
--cc=leitao@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).