* [PATCH] ipv6: add special mode forwarding=2 to send RS while configured as router
@ 2010-09-03 13:04 Thomas Graf
2010-09-03 15:00 ` Stephen Hemminger
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Thomas Graf @ 2010-09-03 13:04 UTC (permalink / raw)
To: netdev; +Cc: davem, yoshfuji
Similar to accepting router advertisement, the IPv6 stack does not send router
solicitations if forwarding is enabled.
This patch enables this behavior to be overruled by setting forwarding to the
special value 2.
Signed-off-by: Thomas Graf <tgraf@infradead.org>
Index: net-2.6/net/ipv6/addrconf.c
===================================================================
--- net-2.6.orig/net/ipv6/addrconf.c
+++ net-2.6/net/ipv6/addrconf.c
@@ -2964,7 +2964,8 @@ static void addrconf_dad_completed(struc
start sending router solicitations.
*/
- if (ifp->idev->cnf.forwarding == 0 &&
+ if ((ifp->idev->cnf.forwarding == 0 ||
+ ifp->idev->cnf.forwarding == 2) &&
ifp->idev->cnf.rtr_solicits > 0 &&
(dev->flags&IFF_LOOPBACK) == 0 &&
(ipv6_addr_type(&ifp->addr) & IPV6_ADDR_LINKLOCAL)) {
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ipv6: add special mode forwarding=2 to send RS while configured as router
2010-09-03 13:04 [PATCH] ipv6: add special mode forwarding=2 to send RS while configured as router Thomas Graf
@ 2010-09-03 15:00 ` Stephen Hemminger
2010-09-03 16:43 ` David Miller
2010-11-24 18:03 ` Daniel Roesen
2 siblings, 0 replies; 5+ messages in thread
From: Stephen Hemminger @ 2010-09-03 15:00 UTC (permalink / raw)
To: Thomas Graf; +Cc: netdev, davem, yoshfuji
On Fri, 3 Sep 2010 09:04:20 -0400
Thomas Graf <tgraf@infradead.org> wrote:
> Similar to accepting router advertisement, the IPv6 stack does not send router
> solicitations if forwarding is enabled.
>
> This patch enables this behavior to be overruled by setting forwarding to the
> special value 2.
>
> Signed-off-by: Thomas Graf <tgraf@infradead.org>
>
Please add description to Documentation/networking/ip-sysctl.txt
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ipv6: add special mode forwarding=2 to send RS while configured as router
2010-09-03 13:04 [PATCH] ipv6: add special mode forwarding=2 to send RS while configured as router Thomas Graf
2010-09-03 15:00 ` Stephen Hemminger
@ 2010-09-03 16:43 ` David Miller
2010-11-24 18:03 ` Daniel Roesen
2 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2010-09-03 16:43 UTC (permalink / raw)
To: tgraf; +Cc: netdev, davem, yoshfuji
From: Thomas Graf <tgraf@infradead.org>
Date: Fri, 3 Sep 2010 09:04:20 -0400
> Similar to accepting router advertisement, the IPv6 stack does not send router
> solicitations if forwarding is enabled.
>
> This patch enables this behavior to be overruled by setting forwarding to the
> special value 2.
>
> Signed-off-by: Thomas Graf <tgraf@infradead.org>
Applied.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ipv6: add special mode forwarding=2 to send RS while configured as router
2010-09-03 13:04 [PATCH] ipv6: add special mode forwarding=2 to send RS while configured as router Thomas Graf
2010-09-03 15:00 ` Stephen Hemminger
2010-09-03 16:43 ` David Miller
@ 2010-11-24 18:03 ` Daniel Roesen
2010-12-06 11:26 ` Thomas Graf
2 siblings, 1 reply; 5+ messages in thread
From: Daniel Roesen @ 2010-11-24 18:03 UTC (permalink / raw)
To: netdev, davem, yoshfuji
Hi,
On Fri, Sep 03, 2010 at 09:04:20AM -0400, Thomas Graf wrote:
> Similar to accepting router advertisement, the IPv6 stack does not send router
> solicitations if forwarding is enabled.
>
> This patch enables this behavior to be overruled by setting forwarding to the
> special value 2.
Wouldn't it be more elegant to use accept_ra=2 as trigger instead of a new special
value for the forwarding option?
Best regards,
Daniel
--
CLUE-RIPE -- Jabber: dr@cluenet.de -- dr@IRCnet -- PGP: 0xA85C8AA0
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ipv6: add special mode forwarding=2 to send RS while configured as router
2010-11-24 18:03 ` Daniel Roesen
@ 2010-12-06 11:26 ` Thomas Graf
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Graf @ 2010-12-06 11:26 UTC (permalink / raw)
To: netdev, davem, yoshfuji
On Wed, Nov 24, 2010 at 07:03:06PM +0100, Daniel Roesen wrote:
> On Fri, Sep 03, 2010 at 09:04:20AM -0400, Thomas Graf wrote:
> > Similar to accepting router advertisement, the IPv6 stack does not send router
> > solicitations if forwarding is enabled.
> >
> > This patch enables this behavior to be overruled by setting forwarding to the
> > special value 2.
>
> Wouldn't it be more elegant to use accept_ra=2 as trigger instead of a new special
> value for the forwarding option?
Two reasons: I didn't want to change the behaviour of an existing
configuration option on which someone may rely on and I wanted to
allow sending of RS while still allowing to disable accepting RAs.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-12-06 11:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-03 13:04 [PATCH] ipv6: add special mode forwarding=2 to send RS while configured as router Thomas Graf
2010-09-03 15:00 ` Stephen Hemminger
2010-09-03 16:43 ` David Miller
2010-11-24 18:03 ` Daniel Roesen
2010-12-06 11:26 ` Thomas Graf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).