From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Gustavo F. Padovan" Subject: Re: [PATCH 1/2] vsprintf: Add %pMbt, bluetooth mac address Date: Mon, 6 Dec 2010 16:11:27 -0200 Message-ID: <20101206181127.GB883@vigoh> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Marcel Holtmann , linux-kernel@vger.kernel.org, netdev@vger.kernel.org To: Joe Perches Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Hi Joe, * Joe Perches [2010-12-03 18:33:03 -0800]: > Bluetooth output the MAC address in reverse order. > Bluetooth memory order: 00 01 02 03 04 05 is output "05:04:03:02:01:00". > > This can save overall text when bluetooth is compiled in. > > Bluetooth currently uses a very slightly unsafe local function (batostr) > to output these formatted addresses. > > Adding %pMbt allows the batostr function to be removed. > > For x86: > > $ size lib/vsprintf*.o* > text data bss dec hex filename > 8189 0 2 8191 1fff lib/vsprintf.o.defconfig.new > 8150 0 2 8152 1fd8 lib/vsprintf.o.defconfig.old > 18633 56 3936 22625 5861 lib/vsprintf.o.allyesconfig.new > 18571 56 3920 22547 5813 lib/vsprintf.o.allyesconfig.old > > Signed-off-by: Joe Perches Looks good to me. Acked-by: Gustavo F. Padovan -- Gustavo F. Padovan http://profusion.mobi