From: Michael Leun <lkml20101129@newton.leun.net>
To: Jesse Gross <jesse@nicira.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
David Miller <davem@davemloft.net>,
Ben Greear <greearb@candelatech.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 2.6.36] vlan: Avoid hwaccel vlan packets when vid not used
Date: Mon, 6 Dec 2010 20:34:37 +0100 [thread overview]
Message-ID: <20101206203437.54b550e0@xenia.leun.net> (raw)
In-Reply-To: <AANLkTikrDTCDxsyOG4m0XcrOY=3pTRwWqnPGsio9cBFj@mail.gmail.com>
On Mon, 6 Dec 2010 10:14:55 -0800
Jesse Gross <jesse@nicira.com> wrote:
> On Sun, Dec 5, 2010 at 2:44 AM, Michael Leun
> <lkml20101129@newton.leun.net> wrote:
> > Hi Jesse,
> >
> > On Sun, 5 Dec 2010 10:55:28 +0100
> > Michael Leun <lkml20101129@newton.leun.net> wrote:
> >
> >> On Sun, 05 Dec 2010 09:03:53 +0100
> >> Eric Dumazet <eric.dumazet@gmail.com> wrote:
> >>
> >> > > But on
> >> > >
> >> > > hpdl320g5:/home/ml # lspci | grep Eth
> >> > > 03:04.0 Ethernet controller: Broadcom Corporation NetXtreme
> >> > > BCM5714 Gigabit Ethernet (rev a3) 03:04.1 Ethernet controller:
> >> > > Broadcom Corporation NetXtreme BCM5714 Gigabit Ethernet (rev
> >> > > a3)
> >> > >
> >> > > the good message is that it also does not crash, but with
> >> > > tcpdump I see vlan tags when no vlan devices configured on the
> >> > > respective eth, if so I do not see tags anymore vlan tags on
> >> > > the trunk interface.
> >> > >
> >> >
> >> > For all these very specific needs, you'll have to try 2.6.37 I am
> >> > afraid. Jesse did huge changes to exactly make this working, we
> >> > wont backport this to 2.6.36, but only avoid crashes.
> >>
> >> OK, I'm perfectly fine with that, of course, actually nice to hear
> >> that the issue already is addressed.
> >>
> >> Likely I'll give some rc an shot on this machine (maybe over
> >> christmas), but it is an production machine (acutally testing other
> >> devices is the "product" produced on this machine), so
> >> unfortunately I'm not that free in when and what I can do (but the
> >> possibility to, for example, bridge the trunk interface would make
> >> testing easier, that justifies something...).
> >>
> >> Thank you all very much for your work.
> >
> > Are these changes already in 2.6.37-rc4? Or, if not are they
> > somewhere publically available already?
> >
> > I looked into various changelogs but have some difficulties to
> > identify them...
> >
> > Maybe I have some time next days to give them an try...
>
> Yes, all of the existing vlan changes are in 2.6.37-rc4. There were a
> number of patches but the main one was
> 3701e51382a026cba10c60b03efabe534fba4ca4
Then, I'm afraid, this (seeing vlan tags even if vlan interfaces are
configured) does not work on HP DL320G5 (for exact description and
examples please see my mail a few days ago).
--
MfG,
Michael Leun
next prev parent reply other threads:[~2010-12-06 19:34 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-29 19:17 2.6.35 -> 2.6.36 panic when vlan and promisc with tg3 Michael Leun
2010-11-30 0:19 ` Ben Greear
2010-11-30 3:10 ` Jesse Gross
2010-11-30 3:26 ` David Miller
2010-11-30 8:59 ` Michael Leun
2010-11-30 9:20 ` Eric Dumazet
2010-11-30 22:27 ` Jesse Gross
2010-12-01 10:17 ` Michael Leun
2010-12-01 10:55 ` [PATCH 2.6.36] vlan: Avoid hwaccel vlan packets when vid not used Eric Dumazet
2010-12-05 2:07 ` Michael Leun
2010-12-05 8:03 ` Eric Dumazet
2010-12-05 9:55 ` Michael Leun
[not found] ` <20101205114404.7c0cddc2@xenia.leun.net>
[not found] ` <AANLkTikrDTCDxsyOG4m0XcrOY=3pTRwWqnPGsio9cBFj@mail.gmail.com>
2010-12-06 19:34 ` Michael Leun [this message]
2010-12-06 20:04 ` Jesse Gross
2010-12-06 21:27 ` Michael Leun
2010-12-13 0:11 ` Jesse Gross
2010-12-13 22:45 ` Matt Carlson
2010-12-14 4:07 ` Jesse Gross
2010-12-14 19:15 ` Matt Carlson
2010-12-14 21:46 ` Jesse Gross
2010-12-15 0:24 ` Michael Leun
2010-12-15 1:34 ` Matt Carlson
2010-12-15 7:16 ` Michael Leun
2010-12-19 3:38 ` Jesse Gross
2011-01-07 3:24 ` Matt Carlson
2011-01-07 4:36 ` Jesse Gross
2011-01-13 1:21 ` Matt Carlson
2011-01-13 15:06 ` Jesse Gross
2011-01-13 20:50 ` Matt Carlson
2011-01-13 21:58 ` Jesse Gross
2011-01-14 1:15 ` Matt Carlson
2011-01-14 17:49 ` Jesse Gross
2011-01-14 18:38 ` Matt Carlson
2011-01-19 16:15 ` Jesse Gross
2011-01-01 17:03 ` Eric Dumazet
2011-01-02 0:27 ` Jesse Gross
2011-01-02 16:05 ` Eric Dumazet
2011-01-06 21:01 ` Jesse Gross
2011-01-06 23:34 ` Eric Dumazet
2011-01-07 1:20 ` Eric Dumazet
2011-01-07 2:29 ` Matt Carlson
2011-01-07 2:41 ` Eric Dumazet
2011-01-07 2:43 ` Eric Dumazet
2011-01-07 2:59 ` Matt Carlson
2011-01-07 3:04 ` Eric Dumazet
2011-01-07 3:41 ` Matt Carlson
2011-01-07 3:54 ` Eric Dumazet
2011-01-07 4:38 ` Jesse Gross
2010-12-08 16:47 ` David Miller
2010-12-08 23:06 ` [stable] " Greg KH
2010-12-08 23:16 ` Greg KH
2010-12-09 1:25 ` Eric Dumazet
2010-12-09 20:13 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101206203437.54b550e0@xenia.leun.net \
--to=lkml20101129@newton.leun.net \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=greearb@candelatech.com \
--cc=jesse@nicira.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).