From: "John W. Linville" <linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
To: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
Cc: "Luis R. Rodriguez"
<lrodriguez-DlyHzToyqoxBDgjK7y7TUQ@public.gmane.org>,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
ath5k-devel-juf53994utBLZpfksSYvnA@public.gmane.org,
ath9k-devel-juf53994utBLZpfksSYvnA@public.gmane.org,
Peter Stuge <peter-Y+HMSxxDrH8@public.gmane.org>,
Felix Fietkau <nbd-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 0/4] ath: logging message conversion
Date: Tue, 7 Dec 2010 14:05:28 -0500 [thread overview]
Message-ID: <20101207190528.GD2700@tuxdriver.com> (raw)
In-Reply-To: <cover.1291333543.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
On Thu, Dec 02, 2010 at 07:12:34PM -0800, Joe Perches wrote:
> ath_print is misleading as it's only used with CONFIG_ATH_DEBUG.
>
> Add and use the more normal <subsystem>_printk and <subsystem>_<level>
> printk equivalents. (ath_printk and ath_<level>)
>
> Fix various defects in the current uses of ath_print formats
> and arguments: Unnecessary casts, missing newlines, multiple
> prints, and 1 loop which can exceed array bounds.
>
> Bundled and integrated the individual patches into a single patch series.
>
> Joe Perches (4):
> ath: Add and use ath_printk and ath_<level>
> ath: Convert ath_print(.., ATH_DBG_FATAL to ath_err
> ath: Convert ath_print to ath_dbg
> ath: Fix ath_dbg access beyond array bound
Is the Atheros crew happy with this series? They didn't seem to like
the original patches very much...
John
--
John W. Linville Someday the world will need a hero, and you
linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org might be all we have. Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-12-07 19:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-02 5:13 [PATCH 1/2] ath: Fix ath_dbg uses missing newlines and access beyond array bound Joe Perches
[not found] ` <276469c602c402565b49f99521ea19757429e81e.1291266731.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2010-12-02 5:13 ` [PATCH 2/2] ath: Fix logging message typos Joe Perches
2010-12-02 5:30 ` Peter Stuge
[not found] ` <20101202053055.19479.qmail-Y+HMSxxDrH8@public.gmane.org>
2010-12-02 5:34 ` [ath9k-devel] " Joe Perches
2010-12-02 6:01 ` Nick Kossifidis
2010-12-02 5:35 ` [PATCH 2/2 V2] " Joe Perches
2010-12-02 19:02 ` [PATCH 1/2] ath: Fix ath_dbg uses missing newlines and access beyond array bound Luis R. Rodriguez
2010-12-03 3:12 ` [PATCH 0/4] ath: logging message conversion Joe Perches
2010-12-03 3:12 ` [PATCH 1/4] ath: Add and use ath_printk and ath_<level> Joe Perches
2010-12-07 21:38 ` John W. Linville
2010-12-03 3:12 ` [PATCH 2/4] ath: Convert ath_print(.., ATH_DBG_FATAL to ath_err Joe Perches
2010-12-03 3:12 ` [PATCH 3/4] ath: Convert ath_print to ath_dbg Joe Perches
2010-12-03 3:12 ` [PATCH 4/4] ath: Fix ath_dbg access beyond array bound Joe Perches
[not found] ` <cover.1291333543.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2010-12-07 19:05 ` John W. Linville [this message]
2010-12-07 19:26 ` [PATCH 0/4] ath: logging message conversion Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101207190528.GD2700@tuxdriver.com \
--to=linville-2xusbdqka4r54taoqtywwq@public.gmane.org \
--cc=ath5k-devel-juf53994utBLZpfksSYvnA@public.gmane.org \
--cc=ath9k-devel-juf53994utBLZpfksSYvnA@public.gmane.org \
--cc=joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lrodriguez-DlyHzToyqoxBDgjK7y7TUQ@public.gmane.org \
--cc=nbd-p3rKhJxN3npAfugRpC6u6w@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=peter-Y+HMSxxDrH8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).