From: "Luis R. Rodriguez" <lrodriguez@atheros.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: Joe Perches <joe@perches.com>,
Luis Rodriguez <Luis.Rodriguez@Atheros.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"ath5k-devel@venema.h4ckr.net" <ath5k-devel@venema.h4ckr.net>,
"ath9k-devel@venema.h4ckr.net" <ath9k-devel@venema.h4ckr.net>,
Peter Stuge <peter@stuge.se>, Felix Fietkau <nbd@openwrt.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH 0/4] ath: logging message conversion
Date: Tue, 7 Dec 2010 11:26:04 -0800 [thread overview]
Message-ID: <20101207192604.GA2582@tux> (raw)
In-Reply-To: <20101207190528.GD2700@tuxdriver.com>
On Tue, Dec 07, 2010 at 11:05:28AM -0800, John W. Linville wrote:
> On Thu, Dec 02, 2010 at 07:12:34PM -0800, Joe Perches wrote:
> > ath_print is misleading as it's only used with CONFIG_ATH_DEBUG.
> >
> > Add and use the more normal <subsystem>_printk and <subsystem>_<level>
> > printk equivalents. (ath_printk and ath_<level>)
> >
> > Fix various defects in the current uses of ath_print formats
> > and arguments: Unnecessary casts, missing newlines, multiple
> > prints, and 1 loop which can exceed array bounds.
> >
> > Bundled and integrated the individual patches into a single patch series.
> >
> > Joe Perches (4):
> > ath: Add and use ath_printk and ath_<level>
> > ath: Convert ath_print(.., ATH_DBG_FATAL to ath_err
> > ath: Convert ath_print to ath_dbg
> > ath: Fix ath_dbg access beyond array bound
>
> Is the Atheros crew happy with this series? They didn't seem to like
> the original patches very much...
Its fine now that Joe has addressed some more important items.
But I'd like for the patches to be applied last of all pending
patches :)
Luis
prev parent reply other threads:[~2010-12-07 19:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-02 5:13 [PATCH 1/2] ath: Fix ath_dbg uses missing newlines and access beyond array bound Joe Perches
[not found] ` <276469c602c402565b49f99521ea19757429e81e.1291266731.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2010-12-02 5:13 ` [PATCH 2/2] ath: Fix logging message typos Joe Perches
2010-12-02 5:30 ` Peter Stuge
[not found] ` <20101202053055.19479.qmail-Y+HMSxxDrH8@public.gmane.org>
2010-12-02 5:34 ` [ath9k-devel] " Joe Perches
2010-12-02 6:01 ` Nick Kossifidis
2010-12-02 5:35 ` [PATCH 2/2 V2] " Joe Perches
2010-12-02 19:02 ` [PATCH 1/2] ath: Fix ath_dbg uses missing newlines and access beyond array bound Luis R. Rodriguez
2010-12-03 3:12 ` [PATCH 0/4] ath: logging message conversion Joe Perches
2010-12-03 3:12 ` [PATCH 1/4] ath: Add and use ath_printk and ath_<level> Joe Perches
2010-12-07 21:38 ` John W. Linville
2010-12-03 3:12 ` [PATCH 2/4] ath: Convert ath_print(.., ATH_DBG_FATAL to ath_err Joe Perches
2010-12-03 3:12 ` [PATCH 3/4] ath: Convert ath_print to ath_dbg Joe Perches
2010-12-03 3:12 ` [PATCH 4/4] ath: Fix ath_dbg access beyond array bound Joe Perches
[not found] ` <cover.1291333543.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2010-12-07 19:05 ` [PATCH 0/4] ath: logging message conversion John W. Linville
2010-12-07 19:26 ` Luis R. Rodriguez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101207192604.GA2582@tux \
--to=lrodriguez@atheros.com \
--cc=Luis.Rodriguez@Atheros.com \
--cc=ath5k-devel@venema.h4ckr.net \
--cc=ath9k-devel@venema.h4ckr.net \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=nbd@openwrt.org \
--cc=netdev@vger.kernel.org \
--cc=peter@stuge.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).