netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: andreas.fenkart@streamunlimited.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 1/1] arcvmac submit #4a.
Date: Wed, 08 Dec 2010 09:00:40 -0800 (PST)	[thread overview]
Message-ID: <20101208.090040.39174008.davem@davemloft.net> (raw)
In-Reply-To: <1291296112-27784-1-git-send-email-andreas.fenkart@streamunlimited.com>

From: Andreas Fenkart <andreas.fenkart@streamunlimited.com>
Date: Thu,  2 Dec 2010 14:21:52 +0100

> 
> Signed-off-by: Andreas Fenkart <andreas.fenkart@streamunlimited.com>

Generates many warnings on 64-bit platforms, also doesn't build on any
platform because it uses interfaces we removed a long time ago
(multicast count and list).

If you want anyone to take your submission seriously, at the very
least you should at least test the build against current sources
before submitting.

drivers/net/arcvmac.c: In function ‘vmac_ioctl’:
drivers/net/arcvmac.c:333: warning: passing argument 2 of ‘phy_mii_ioctl’ from incompatible pointer type
include/linux/phy.h:511: note: expected ‘struct ifreq *’ but argument is of type ‘struct mii_ioctl_data *’
drivers/net/arcvmac.c: In function ‘vmacether_get_drvinfo’:
drivers/net/arcvmac.c:344: warning: format ‘%x’ expects type ‘unsigned int’, but argument 4 has type ‘resource_size_t’
drivers/net/arcvmac.c: In function ‘alloc_buffers_unlocked’:
drivers/net/arcvmac.c:966: warning: cast from pointer to integer of different size
drivers/net/arcvmac.c:966: warning: cast from pointer to integer of different size
drivers/net/arcvmac.c: In function ‘create_multicast_filter’:
drivers/net/arcvmac.c:1260: error: ‘struct net_device’ has no member named ‘mc_count’
drivers/net/arcvmac.c:1264: error: ‘struct net_device’ has no member named ‘mc_list’
drivers/net/arcvmac.c:1264: error: dereferencing pointer to incomplete type
drivers/net/arcvmac.c:1265: error: dereferencing pointer to incomplete type
drivers/net/arcvmac.c: In function ‘vmac_set_multicast_list’:
drivers/net/arcvmac.c:1293: error: ‘struct net_device’ has no member named ‘mc_count’
drivers/net/arcvmac.c: In function ‘vmac_probe’:
drivers/net/arcvmac.c:1438: warning: format ‘%08x’ expects type ‘unsigned int’, bu

  reply	other threads:[~2010-12-08 17:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-15  7:54 [PATCH 0/1] ARC vmac ethernet driver Andreas Fenkart
2010-10-15  7:54 ` [PATCH 1/1] " Andreas Fenkart
2010-10-19 13:53   ` David Miller
2010-12-02 12:39     ` Andreas Fenkart
2010-12-02 12:46       ` [PATCH 1/1] arcvmac submit #4 Andreas Fenkart
2010-12-02 13:10         ` Andreas Fenkart
2010-12-02 13:21           ` [PATCH 1/1] arcvmac submit #4a Andreas Fenkart
2010-12-08 17:00             ` David Miller [this message]
2011-02-15  9:31               ` [PATCH 1/1] ARC VMAC ethernet driver Andreas Fenkart
2011-02-15 10:02                 ` Eric Dumazet
2011-02-17  9:26                   ` Andreas Fenkart
2011-02-17  9:31                     ` Andreas Fenkart
2011-02-17 10:13                       ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101208.090040.39174008.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=andreas.fenkart@streamunlimited.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).