From: David Miller <davem@davemloft.net>
To: hadi@cyberus.ca
Cc: xiaosuo@gmail.com, jarkao2@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-2.6] ifb: goto resched directly if error happens and dp->tq isn't empty
Date: Wed, 08 Dec 2010 09:45:52 -0800 (PST) [thread overview]
Message-ID: <20101208.094552.179947046.davem@davemloft.net> (raw)
In-Reply-To: <1291559144.2159.682.camel@mojatatu>
From: jamal <hadi@cyberus.ca>
Date: Sun, 05 Dec 2010 09:25:44 -0500
> On Sun, 2010-12-05 at 08:09 +0800, Changli Gao wrote:
>> If we break the loop when there are still skbs in tq and no skb in
>> rq, the skbs will be left in txq until new skbs are enqueued into rq.
>> In rare cases, no new skb is queued, then these skbs will stay in rq
>> forever.
>>
>> After this patch, if tq isn't empty when we break the loop, we goto
>> resched directly.
>>
>> Signed-off-by: Changli Gao <xiaosuo@gmail.com>
>
> Signed-off-by: Jamal Hadi Salim <hadi@cyberus.ca>
>
> Dave, this goes to stable as well.
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2010-12-08 17:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-05 0:09 [PATCH net-2.6] ifb: goto resched directly if error happens and dp->tq isn't empty Changli Gao
2010-12-05 14:25 ` jamal
2010-12-08 17:45 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101208.094552.179947046.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=jarkao2@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).