* [patch 1/1] driver/net/benet: fix be_cmd_multicast_set() memcpy bug
@ 2010-12-06 13:00 Joe Jin
2010-12-08 18:27 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Joe Jin @ 2010-12-06 13:00 UTC (permalink / raw)
To: sathyap, subbus, sarveshwarb, ajitk
Cc: netdev, linux-kernel, greg.marsden, guru.anbalagane, joe.jin
Hi,
Regarding benet be_cmd_multicast_set() function, now using
netdev_for_each_mc_addr() helper for mac address copy, but
when copying to req->mac[] did not increase of the index.
Cc: Sathya Perla <sathyap@serverengines.com>
Cc: Subbu Seetharaman <subbus@serverengines.com>
Cc: Sarveshwar Bandi <sarveshwarb@serverengines.com>
Cc: Ajit Khaparde <ajitk@serverengines.com>
Signed-off-by: Joe Jin <joe.jin@oracle.com>
---
be_cmds.c | 2 +-
diff --git a/drivers/net/benet/be_cmds.c b/drivers/net/benet/be_cmds.c
index 36eca1c..e4465d2 100644
--- a/drivers/net/benet/be_cmds.c
+++ b/drivers/net/benet/be_cmds.c
@@ -1235,7 +1235,7 @@ int be_cmd_multicast_set(struct be_adapter *adapter, u32 if_id,
i = 0;
netdev_for_each_mc_addr(ha, netdev)
- memcpy(req->mac[i].byte, ha->addr, ETH_ALEN);
+ memcpy(req->mac[i++].byte, ha->addr, ETH_ALEN);
} else {
req->promiscuous = 1;
}
--
Oracle <http://www.oracle.com>
Joe Jin | Team Leader, Software Development | +8610.8278.6295
ORACLE | Linux and Virtualization
Incubator Building 2-A ZPark | Beijing China, 100094
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [patch 1/1] driver/net/benet: fix be_cmd_multicast_set() memcpy bug
2010-12-06 13:00 [patch 1/1] driver/net/benet: fix be_cmd_multicast_set() memcpy bug Joe Jin
@ 2010-12-08 18:27 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-12-08 18:27 UTC (permalink / raw)
To: joe.jin
Cc: sathyap, subbus, sarveshwarb, ajitk, netdev, linux-kernel,
greg.marsden, guru.anbalagane
From: Joe Jin <joe.jin@oracle.com>
Date: Mon, 6 Dec 2010 21:00:59 +0800
> Hi,
>
> Regarding benet be_cmd_multicast_set() function, now using
> netdev_for_each_mc_addr() helper for mac address copy, but
> when copying to req->mac[] did not increase of the index.
>
> Cc: Sathya Perla <sathyap@serverengines.com>
> Cc: Subbu Seetharaman <subbus@serverengines.com>
> Cc: Sarveshwar Bandi <sarveshwarb@serverengines.com>
> Cc: Ajit Khaparde <ajitk@serverengines.com>
> Signed-off-by: Joe Jin <joe.jin@oracle.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-12-08 18:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-06 13:00 [patch 1/1] driver/net/benet: fix be_cmd_multicast_set() memcpy bug Joe Jin
2010-12-08 18:27 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).