netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] isdn/hisax: fix compiler warning on hisax_pci_tbl
@ 2010-12-07 14:49 Namhyung Kim
  2010-12-08 18:51 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Namhyung Kim @ 2010-12-07 14:49 UTC (permalink / raw)
  To: Karsten Keil; +Cc: netdev, linux-kernel

Annotate hisax_pci_tbl as '__used' to fix following warning:

  CC      drivers/isdn/hisax/config.o
drivers/isdn/hisax/config.c:1920: warning: ‘hisax_pci_tbl’ defined but not used

Signed-off-by: Namhyung Kim <namhyung@gmail.com>
---
 drivers/isdn/hisax/config.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/isdn/hisax/config.c b/drivers/isdn/hisax/config.c
index b133378..c110f86 100644
--- a/drivers/isdn/hisax/config.c
+++ b/drivers/isdn/hisax/config.c
@@ -1917,7 +1917,7 @@ static void EChannel_proc_rcv(struct hisax_d_if *d_if)
 #ifdef CONFIG_PCI
 #include <linux/pci.h>
 
-static struct pci_device_id hisax_pci_tbl[] __devinitdata = {
+static struct pci_device_id hisax_pci_tbl[] __devinitdata __used = {
 #ifdef CONFIG_HISAX_FRITZPCI
 	{PCI_VDEVICE(AVM,      PCI_DEVICE_ID_AVM_A1)			},
 #endif
-- 
1.7.0.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] isdn/hisax: fix compiler warning on hisax_pci_tbl
  2010-12-07 14:49 [PATCH] isdn/hisax: fix compiler warning on hisax_pci_tbl Namhyung Kim
@ 2010-12-08 18:51 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-12-08 18:51 UTC (permalink / raw)
  To: namhyung; +Cc: isdn, netdev, linux-kernel

From: Namhyung Kim <namhyung@gmail.com>
Date: Tue,  7 Dec 2010 23:49:06 +0900

> Annotate hisax_pci_tbl as '__used' to fix following warning:
> 
>   CC      drivers/isdn/hisax/config.o
> drivers/isdn/hisax/config.c:1920: warning: ‘hisax_pci_tbl’ defined but not used
> 
> Signed-off-by: Namhyung Kim <namhyung@gmail.com>

This only happens because the hisax driver doesn't actually use this table
for probing.  Each sub-driver does it's own thing.

What a mess.

Anyways, applied, thank you.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-12-08 18:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-07 14:49 [PATCH] isdn/hisax: fix compiler warning on hisax_pci_tbl Namhyung Kim
2010-12-08 18:51 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).