From: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
To: kay.sievers-tD+1rO4QERM@public.gmane.org
Cc: dcbw-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
duncan.sands-GANU6spQydw@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
chas-vT06rRrALxcmhCb6mdbn6A@public.gmane.org
Subject: Re: [PATCH] atm: correct sysfs 'device' link creation and parent relationships
Date: Wed, 08 Dec 2010 12:15:32 -0800 (PST) [thread overview]
Message-ID: <20101208.121532.232745367.davem@davemloft.net> (raw)
In-Reply-To: <20101208.101121.71114237.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
From: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Date: Wed, 08 Dec 2010 10:11:21 -0800 (PST)
> From: Kay Sievers <kay.sievers-tD+1rO4QERM@public.gmane.org>
> Date: Tue, 7 Dec 2010 08:35:53 +0100
>
>> On Sun, Dec 5, 2010 at 23:17, Dan Williams <dcbw-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
>>> The ATM subsystem was incorrectly creating the 'device' link for ATM
>>> nodes in sysfs. This led to incorrect device/parent relationships
>>> exposed by sysfs and udev. Instead of rolling the 'device' link by hand
>>> in the generic ATM code, pass each ATM driver's bus device down to the
>>> sysfs code and let sysfs do this stuff correctly.
>>
>> Looks good to me.
>
> I've applied this to net-2.6, thanks Dan.
Actually I'm reverting, it breaks the build.
Did you even grep for "atm_dev_register()" after changning the number
of arguments, or were you depending upon build failures to guide you?
Please never do the latter, as it always leads to things like this.
drivers/atm/fore200e.c:2577:7: error: too few arguments to function 'atm_dev_register'
drivers/atm/iphase.c:3175:2: error: too few arguments to function 'atm_dev_register'
...
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-12-08 20:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-05 22:17 [PATCH] atm: correct sysfs 'device' link creation and parent relationships Dan Williams
2010-12-07 7:35 ` Kay Sievers
2010-12-08 18:11 ` David Miller
[not found] ` <20101208.101121.71114237.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2010-12-08 20:15 ` David Miller [this message]
[not found] ` <20101208.121532.232745367.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2010-12-09 0:33 ` Dan Williams
2010-12-09 5:40 ` [PATCH v2] " Dan Williams
2010-12-10 23:45 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101208.121532.232745367.davem@davemloft.net \
--to=davem-ft/pcqaiutieiz0/mpfg9q@public.gmane.org \
--cc=chas-vT06rRrALxcmhCb6mdbn6A@public.gmane.org \
--cc=dcbw-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=duncan.sands-GANU6spQydw@public.gmane.org \
--cc=kay.sievers-tD+1rO4QERM@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).