* [PATCH] IP checksuming doesn't work on GE0301 option cards
@ 2010-12-08 8:21 Thomas Bogendoerfer
2010-12-10 4:43 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Bogendoerfer @ 2010-12-08 8:21 UTC (permalink / raw)
To: netdev, j.dumon
There is definitly a problem, that some option cards send up broken
IP pakets leading to corrupted IP packets. These corruptions aren't
detected, because the driver claims that the packets are already
checksummed. This change removes the CHECKSUM_UNNECESSARY option
and let IP detect broken data.
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
---
drivers/net/usb/hso.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
index b154a94..1f94f92 100644
--- a/drivers/net/usb/hso.c
+++ b/drivers/net/usb/hso.c
@@ -958,10 +958,6 @@ static void packetizeRx(struct hso_net *odev, unsigned char *ip_pkt,
/* Packet is complete. Inject into stack. */
/* We have IP packet here */
odev->skb_rx_buf->protocol = cpu_to_be16(ETH_P_IP);
- /* don't check it */
- odev->skb_rx_buf->ip_summed =
- CHECKSUM_UNNECESSARY;
-
skb_reset_mac_header(odev->skb_rx_buf);
/* Ship it off to the kernel */
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] IP checksuming doesn't work on GE0301 option cards
2010-12-08 8:21 [PATCH] IP checksuming doesn't work on GE0301 option cards Thomas Bogendoerfer
@ 2010-12-10 4:43 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-12-10 4:43 UTC (permalink / raw)
To: tsbogend; +Cc: netdev, j.dumon
From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Date: Wed, 8 Dec 2010 09:21:52 +0100 (CET)
> There is definitly a problem, that some option cards send up broken
> IP pakets leading to corrupted IP packets. These corruptions aren't
> detected, because the driver claims that the packets are already
> checksummed. This change removes the CHECKSUM_UNNECESSARY option
> and let IP detect broken data.
>
> Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Applied, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-12-10 4:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-08 8:21 [PATCH] IP checksuming doesn't work on GE0301 option cards Thomas Bogendoerfer
2010-12-10 4:43 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).