[PATCH] Link directly to the archive files rather than using search paths.

[PATCH] Link directly to the archive files rather than using search paths.

[Diego Elio Pettenò]

While the previous code was supposed to work nonetheless, it could be
messed up if further -L were used in LDFLAGS to list the path where glibc's
libutil was to be found.

References: https://bugs.gentoo.org/347489

CC: Daniel Kurtz <djkurtz@google.com>
CC: Mike Frysinger <vapier@gentoo.org>
Signed-off-by: Diego Elio Pettenò <flameeyes@gmail.com>
---
 Makefile |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index c03d74c..d1ace1f 100644
--- a/Makefile
+++ b/Makefile
@@ -33,11 +33,10 @@ CCOPTS = -D_GNU_SOURCE -O2 -Wstrict-prototypes -Wall
 CFLAGS = $(CCOPTS) -I../include $(DEFINES)
 YACCFLAGS = -d -t -v
 
-LDLIBS += -L../lib -lnetlink -lutil
-
 SUBDIRS=lib ip tc misc netem genl
 
 LIBNETLINK=../lib/libnetlink.a ../lib/libutil.a
+LDLIBS += $(LIBNETLINK)
 
 all: Config
 	@set -e; \
-- 
1.7.3.3

Re: [PATCH] Link directly to the archive files rather than using search paths.

[Stephen Hemminger]

On Fri, 10 Dec 2010 01:56:12 +0100
Diego Elio Pettenò <flameeyes@gmail.com> wrote:

> While the previous code was supposed to work nonetheless, it could be
> messed up if further -L were used in LDFLAGS to list the path where glibc's
> libutil was to be found.
> 
> References: https://bugs.gentoo.org/347489
> 
> CC: Daniel Kurtz <djkurtz@google.com>
> CC: Mike Frysinger <vapier@gentoo.org>
> Signed-off-by: Diego Elio Pettenò <flameeyes@gmail.com>
> ---
>  Makefile |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index c03d74c..d1ace1f 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -33,11 +33,10 @@ CCOPTS = -D_GNU_SOURCE -O2 -Wstrict-prototypes -Wall
>  CFLAGS = $(CCOPTS) -I../include $(DEFINES)
>  YACCFLAGS = -d -t -v
>  
> -LDLIBS += -L../lib -lnetlink -lutil
> -
>  SUBDIRS=lib ip tc misc netem genl
>  
>  LIBNETLINK=../lib/libnetlink.a ../lib/libutil.a
> +LDLIBS += $(LIBNETLINK)
>  
>  all: Config
>  	@set -e; \

Please be more clear in your subject, yes I can tell this is for
iproute utilities but others may not.

When refering to "previous code" either reply to the original
message thread or provide a link to the changes.

-- 

Re: [PATCH] Link directly to the archive files rather than using search paths.

[Diego Elio Pettenò]

Il giorno gio, 09/12/2010 alle 17.56 -0800, Stephen Hemminger ha
scritto:
> Please be more clear in your subject, yes I can tell this is for
> iproute utilities but others may not.

Sorry, I should have used --subject-prefix, will make sure to set it
into the configuration file for the future.

> When refering to "previous code" either reply to the original
> message thread or provide a link to the changes. 

Uhm, the "previous code" in here is "the Makefile as it was before the
patch", want me to rephrase and resend?

-- 
Diego Elio Pettenò — “Flameeyes”
http://blog.flameeyes.eu/

If you found a .asc file in this mail and know not what it is,
it's a GnuPG digital signature: http://www.gnupg.org/

Re: [PATCH] Link directly to the archive files rather than using search paths.

[Stephen Hemminger]

On Fri, 10 Dec 2010 03:02:00 +0100
Diego Elio Pettenò <flameeyes@gmail.com> wrote:

> Il giorno gio, 09/12/2010 alle 17.56 -0800, Stephen Hemminger ha
> scritto:
> > Please be more clear in your subject, yes I can tell this is for
> > iproute utilities but others may not.
> 
> Sorry, I should have used --subject-prefix, will make sure to set it
> into the configuration file for the future.
> 
> > When refering to "previous code" either reply to the original
> > message thread or provide a link to the changes. 
> 
> Uhm, the "previous code" in here is "the Makefile as it was before the
> patch", want me to rephrase and resend?
> 

No. just wanted to make sure.  I take any fix as long as it is clear
what it is doing. 

--