From: David Miller <davem@davemloft.net>
To: mroos@linux.ee
Cc: j@w1.fi, netdev@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] fix hostap registration order
Date: Fri, 10 Dec 2010 09:47:47 -0800 (PST) [thread overview]
Message-ID: <20101210.094747.193727608.davem@davemloft.net> (raw)
In-Reply-To: <alpine.SOC.1.00.1012100918300.15996@math.ut.ee>
From: Meelis Roos <mroos@linux.ee>
Date: Fri, 10 Dec 2010 09:19:51 +0200 (EET)
>> > In 2.6.37-rc4, hostap_pci init gives a WARNING with backtrace telling
>> > that netif_stop_queue is called before register_netdev. Fix it by moving
>> > this call after register_netdev. Removes the warning and seems to work,
>> > but why is the call to netif_stop_queue needed at all after
>> > register_netdev?
>>
>> It should simply not touch the queue state at all at this point.
>>
>> Your change would add a race. At the moment the device is registered
>> it can be brought up, and then your code will eroneously modify
>> the queue state.
>
> OK, I can make a simpler patch for that but I would like to understand
> the original reasons for having netif_stop_queue there. Just a relict or
> still somehow important?
I think it was neither.
The queue state is "don't care" at this point, and always has been,
and a lot of drivers had this unnecessary netif_stop_queue() call
there.
next prev parent reply other threads:[~2010-12-10 17:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-09 23:19 [PATCH] fix hostap registration order Meelis Roos
2010-12-10 3:53 ` David Miller
2010-12-10 7:19 ` Meelis Roos
2010-12-10 17:47 ` David Miller [this message]
2010-12-17 21:27 ` [PATCH] hostap: remove netif_stop_queue from init Meelis Roos
[not found] ` <alpine.SOC.1.00.1012172324340.24976-ptEonEWSGqKptlylMvRsHA@public.gmane.org>
2010-12-17 21:32 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101210.094747.193727608.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=j@w1.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=mroos@linux.ee \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).