From: David Miller <davem@davemloft.net>
To: romieu@fr.zoreil.com
Cc: rjw@sisk.pl, mjg@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-pm@lists.linux-foundation.org
Subject: Re: [PATCH, post-2.6.36 regression fix] r8169: Fix runtime power management
Date: Fri, 10 Dec 2010 11:09:46 -0800 (PST) [thread overview]
Message-ID: <20101210.110946.260074147.davem@davemloft.net> (raw)
In-Reply-To: <20101209092804.GA4113@electric-eye.fr.zoreil.com>
From: Francois Romieu <romieu@fr.zoreil.com>
Date: Thu, 9 Dec 2010 10:28:04 +0100
> Rafael J. Wysocki <rjw@sisk.pl> :
> [...]
>> I noticed that one of the post-2.6.36 patches broke runtime PM of the
>> r8169 on my MSI Wind test machine in such a way that the link was not
>> brought up after reconnecting the network cable.
>>
>> In the process of debugging the issue I realized that we only should
>> invoke the runtime PM functions in rtl8169_check_link_status() when
>> link change is reported and if we do so, the problem goes away.
>> Moreover, this allows rtl8169_runtime_idle() to be simplified quite
>> a bit.
>>
>> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
>
> Acked-by: Francois Romieu <romieu@fr.zoreil.com>
Applied, thanks.
prev parent reply other threads:[~2010-12-10 19:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-09 1:32 [PATCH, post-2.6.36 regression fix] r8169: Fix runtime power management Rafael J. Wysocki
2010-12-09 9:28 ` Francois Romieu
2010-12-10 19:09 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101210.110946.260074147.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=mjg@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).