From: David Miller <davem@davemloft.net>
To: emil.s.tantilov@intel.com
Cc: joe@perches.com, jeffrey.t.kirsher@intel.com,
davem@davemleft.org, bruce.w.allan@intel.com,
netdev@vger.kernel.org, gospo@redhat.com, bphilips@novell.com
Subject: Re: [net-next-2.6 25/27] e1000e: static analysis tools complain of a possible null ptr p dereference
Date: Fri, 10 Dec 2010 12:16:24 -0800 (PST) [thread overview]
Message-ID: <20101210.121624.245389962.davem@davemloft.net> (raw)
In-Reply-To: <EA929A9653AAE14F841771FB1DE5A136602D54FD2F@rrsmsx501.amr.corp.intel.com>
From: "Tantilov, Emil S" <emil.s.tantilov@intel.com>
Date: Fri, 10 Dec 2010 12:35:45 -0700
> Dave, unless this is infringing on some coding style rule, I would request that the patch be applied as is.
I think Ben's request is more than reasonable. Please make his requested
change. "continue; break;" looks quite silly to me too.
next prev parent reply other threads:[~2010-12-10 20:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-10 10:06 [net-next-2.6 24/27] e1000e: minor error message corrections Jeff Kirsher
2010-12-10 10:06 ` [net-next-2.6 25/27] e1000e: static analysis tools complain of a possible null ptr p dereference Jeff Kirsher
2010-12-10 12:44 ` Joe Perches
2010-12-10 19:35 ` Tantilov, Emil S
2010-12-10 19:58 ` Joe Perches
2010-12-10 20:16 ` David Miller [this message]
2010-12-10 10:06 ` [net-next-2.6 26/27] e1000e: increment the driver version Jeff Kirsher
2010-12-10 10:06 ` [net-next-2.6 27/27] igb: Add new function to read part number from EEPROM in string format Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101210.121624.245389962.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bphilips@novell.com \
--cc=bruce.w.allan@intel.com \
--cc=davem@davemleft.org \
--cc=emil.s.tantilov@intel.com \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).