From: David Miller <davem@davemloft.net>
To: romieu@fr.zoreil.com
Cc: netdev@vger.kernel.org, DavidLv@viatech.com.cn,
ShirleyHu@viatech.com.cn, AndersMa@viatech.com.cn
Subject: Re: [PATCH 1/2] via-velocity: set sleep speed to 10Mbps for powersaving.
Date: Fri, 10 Dec 2010 12:47:42 -0800 (PST) [thread overview]
Message-ID: <20101210.124742.116394707.davem@davemloft.net> (raw)
In-Reply-To: <20101209092656.GA4064@electric-eye.fr.zoreil.com>
From: Francois Romieu <romieu@fr.zoreil.com>
Date: Thu, 9 Dec 2010 10:26:56 +0100
> Signed-off-by: David Lv <DavidLv@viatech.com.cn>
> Acked-by: Francois Romieu <romieu@fr.zoreil.com>
Please, no new module parameters that only have obscure meanings
on specific device types.
This is terrible for users.
I'm not applying these two patches, sorry.
I know it already has the 1000M one, and if I was handling driver patches
directly when that got in I apologize for not catching it, it's wrong too.
There is nothing that prevents adding ethtool facilities for this issue.
In fact looking at the via velocity driver options, many of them
completely duplicate existing ethtool mechanisms. It's beyond a mess.
So I'm putting the line in the sand and will not allow new such options
to be added, sorry.
next prev parent reply other threads:[~2010-12-10 20:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-09 9:26 [PATCH 1/2] via-velocity: set sleep speed to 10Mbps for powersaving Francois Romieu
2010-12-10 20:47 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-12-08 4:10 David Lv
2010-12-08 20:56 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101210.124742.116394707.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=AndersMa@viatech.com.cn \
--cc=DavidLv@viatech.com.cn \
--cc=ShirleyHu@viatech.com.cn \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).