* [PATCH] ipv6: fix nl group when advertising a new link
@ 2010-12-08 9:38 Nicolas Dichtel
2010-12-08 10:04 ` Thomas Graf
0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Dichtel @ 2010-12-08 9:38 UTC (permalink / raw)
To: Thomas Graf, David Miller; +Cc: netdev
[-- Attachment #1: Type: text/plain, Size: 60 bytes --]
Hi,
please consider the following patch.
Regards,
Nicolas
[-- Attachment #2: 0001-ipv6-fix-nl-group-when-advertising-a-new-link.patch --]
[-- Type: text/x-diff, Size: 1145 bytes --]
>From d2ed52e7fcb639470c89045f7b0ce31eb681896a Mon Sep 17 00:00:00 2001
From: Wang Xuefu <xuefu.wang@6wind.com>
Date: Wed, 8 Dec 2010 10:24:48 +0100
Subject: [PATCH] ipv6: fix nl group when advertising a new link
New idev are advertised with NL group RTNLGRP_IPV6_IFADDR, but
should use RTNLGRP_IPV6_IFINFO.
Bug was introduced by commit 8d7a76c9.
Signed-off-by: Wang Xuefu <xuefu.wang@6wind.com>
Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
---
net/ipv6/addrconf.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index ab70a3f..0f695a1 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -4021,11 +4021,11 @@ void inet6_ifinfo_notify(int event, struct inet6_dev *idev)
kfree_skb(skb);
goto errout;
}
- rtnl_notify(skb, net, 0, RTNLGRP_IPV6_IFADDR, NULL, GFP_ATOMIC);
+ rtnl_notify(skb, net, 0, RTNLGRP_IPV6_IFINFO, NULL, GFP_ATOMIC);
return;
errout:
if (err < 0)
- rtnl_set_sk_err(net, RTNLGRP_IPV6_IFADDR, err);
+ rtnl_set_sk_err(net, RTNLGRP_IPV6_IFINFO, err);
}
static inline size_t inet6_prefix_nlmsg_size(void)
--
1.5.6.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ipv6: fix nl group when advertising a new link
2010-12-08 9:38 [PATCH] ipv6: fix nl group when advertising a new link Nicolas Dichtel
@ 2010-12-08 10:04 ` Thomas Graf
2010-12-10 20:49 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Graf @ 2010-12-08 10:04 UTC (permalink / raw)
To: Nicolas Dichtel; +Cc: David Miller, netdev
On Wed, Dec 08, 2010 at 10:38:31AM +0100, Nicolas Dichtel wrote:
> >From d2ed52e7fcb639470c89045f7b0ce31eb681896a Mon Sep 17 00:00:00 2001
> From: Wang Xuefu <xuefu.wang@6wind.com>
> Date: Wed, 8 Dec 2010 10:24:48 +0100
> Subject: [PATCH] ipv6: fix nl group when advertising a new link
>
> New idev are advertised with NL group RTNLGRP_IPV6_IFADDR, but
> should use RTNLGRP_IPV6_IFINFO.
> Bug was introduced by commit 8d7a76c9.
>
> Signed-off-by: Wang Xuefu <xuefu.wang@6wind.com>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Acked-by: Thomas Graf <tgraf@infradead.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ipv6: fix nl group when advertising a new link
2010-12-08 10:04 ` Thomas Graf
@ 2010-12-10 20:49 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2010-12-10 20:49 UTC (permalink / raw)
To: tgraf; +Cc: nicolas.dichtel, netdev
From: Thomas Graf <tgraf@infradead.org>
Date: Wed, 8 Dec 2010 05:04:54 -0500
> On Wed, Dec 08, 2010 at 10:38:31AM +0100, Nicolas Dichtel wrote:
>> >From d2ed52e7fcb639470c89045f7b0ce31eb681896a Mon Sep 17 00:00:00 2001
>> From: Wang Xuefu <xuefu.wang@6wind.com>
>> Date: Wed, 8 Dec 2010 10:24:48 +0100
>> Subject: [PATCH] ipv6: fix nl group when advertising a new link
>>
>> New idev are advertised with NL group RTNLGRP_IPV6_IFADDR, but
>> should use RTNLGRP_IPV6_IFINFO.
>> Bug was introduced by commit 8d7a76c9.
>>
>> Signed-off-by: Wang Xuefu <xuefu.wang@6wind.com>
>> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
>
> Acked-by: Thomas Graf <tgraf@infradead.org>
Applied to net-2.6, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-12-10 20:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-08 9:38 [PATCH] ipv6: fix nl group when advertising a new link Nicolas Dichtel
2010-12-08 10:04 ` Thomas Graf
2010-12-10 20:49 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).