From: David Miller <davem@davemloft.net>
To: pablo@netfilter.org
Cc: netfilter-devel@lists.netfilter.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: ctnetlink loop
Date: Fri, 10 Dec 2010 14:01:46 -0800 (PST) [thread overview]
Message-ID: <20101210.140146.68123509.davem@davemloft.net> (raw)
In-Reply-To: <4D00B5CD.3050406@netfilter.org>
From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Thu, 09 Dec 2010 11:56:13 +0100
> netfilter: ctnetlink: fix loop in ctnetlink_get_conntrack()
>
> From: Pablo Neira Ayuso <pablo@netfilter.org>
>
> This patch fixes a loop in ctnetlink_get_conntrack() that can be
> triggered if you use the same socket to receive events and to
> perform a GET operation. Under heavy load, netlink_unicast()
> may return -EAGAIN, this error code is reserved in nfnetlink for
> the module load-on-demand. Instead, we return -ENOBUFS which is
> the appropriate error code that has to be propagated to
> user-space.
>
> Reported-by: Holger Eitzenberger <holger@eitzenberger.org>
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Since Patrick seems to be inactive I have applied this directly
to net-2.6, thanks guys!
next prev parent reply other threads:[~2010-12-10 22:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-03 13:39 ctnetlink loop Holger Eitzenberger
2010-12-03 13:58 ` Holger Eitzenberger
2010-12-09 10:56 ` Pablo Neira Ayuso
2010-12-09 15:23 ` Holger Eitzenberger
2010-12-10 22:01 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-12-08 17:50 David Miller
2010-12-08 20:31 ` Holger Eitzenberger
2010-12-09 10:39 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101210.140146.68123509.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@lists.netfilter.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).