From: David Miller <davem@davemloft.net>
To: junchangwang@gmail.com
Cc: eric.dumazet@gmail.com, robert.olsson@its.uu.se,
john.r.fastabend@intel.com, andy.shevchenko@gmail.com,
netdev@vger.kernel.org, wangjc@mail.ustc.edu.cn
Subject: Re: [PATCH net-next-2.6] pktgen: adding prefetchw() call
Date: Fri, 10 Dec 2010 15:37:07 -0800 (PST) [thread overview]
Message-ID: <20101210.153707.214218196.davem@davemloft.net> (raw)
In-Reply-To: <20101209025511.GC5379@Desktop-Junchang>
From: Junchang Wang <junchangwang@gmail.com>
Date: Thu, 9 Dec 2010 10:55:16 +0800
> We know for sure pktgen is going to write skb->data right after
> *_alloc_skb, causing unnecessary cache misses.
>
> Idea is to add a prefetchw() call to prefetch the first cache line
> indicated by skb->data. On systems with Adjacent Cache Line Prefetch,
> it's probably two cache lines are prefetched.
>
> With this patch, pktgen on Intel SR1625 server with two E5530
> quad-core processors and a single ixgbe-based NIC went from 8.63Mpps
> to 9.03Mpps, with 4.6% improvement.
>
> Signed-off-by: Junchang Wang <junchangwang@gmail.com>
> Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks.
prev parent reply other threads:[~2010-12-10 23:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-06 6:33 [PATCH net-next-2.6] pktgen: adding prefetchw() call Junchang Wang
2010-12-06 7:26 ` Eric Dumazet
2010-12-08 18:17 ` David Miller
2010-12-09 2:55 ` Junchang Wang
2010-12-10 23:37 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101210.153707.214218196.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andy.shevchenko@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=john.r.fastabend@intel.com \
--cc=junchangwang@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=robert.olsson@its.uu.se \
--cc=wangjc@mail.ustc.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).