Re: [PATCH] iproute2: add dynamic index and name hashes

[Stephen Hemminger <shemminger@vyatta.com>]

On Fri, 10 Dec 2010 16:59:24 +0200
Octavian Purdila <opurdila@ixiacom.com> wrote:

> The hashes sizes start with 16 entries and grow up to 2^20
> entries. The hashes double when the entries in the LL map is greater
> then the hash size.
> 
> Signed-off-by: Octavian Purdila <opurdila@ixiacom.com>
> ---
>  lib/ll_map.c |  125 +++++++++++++++++++++++++++++++++++++++++++++++----------
>  1 files changed, 103 insertions(+), 22 deletions(-)
> 
> diff --git a/lib/ll_map.c b/lib/ll_map.c
> index b8b49aa..9831322 100644
> --- a/lib/ll_map.c
> +++ b/lib/ll_map.c
> @@ -26,7 +26,8 @@ extern unsigned int if_nametoindex (const char *);
>  
>  struct idxmap
>  {
> -	struct idxmap * next;
> +	struct idxmap *idx_next;
> +	struct idxmap *name_next;
>  	unsigned	index;
>  	int		type;
>  	int		alen;
> @@ -35,31 +36,100 @@ struct idxmap
>  	char		name[16];
>  };
>  
> -static struct idxmap *idxmap[16];

This is user space, and memory space is realtively cheap. Why not just
make initial idxmap much bigger and be done with it.


--