* [PATCH] connector: add module alias
@ 2010-12-09 17:36 Stephen Hemminger
2010-12-09 18:47 ` Evgeniy Polyakov
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Hemminger @ 2010-12-09 17:36 UTC (permalink / raw)
To: Evgeniy Polyakov; +Cc: netdev
Since connector can be built as a module and uses netlink socket
to communicate. The module should have an alias to autoload when socket
of NETLINK_CONNECTOR type is requested.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/drivers/connector/connector.c 2010-12-09 09:19:05.549120343 -0800
+++ b/drivers/connector/connector.c 2010-12-09 09:19:52.795051458 -0800
@@ -36,6 +36,7 @@
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Evgeniy Polyakov <zbr@ioremap.net>");
MODULE_DESCRIPTION("Generic userspace <-> kernelspace connector.");
+MODULE_ALIAS_NET_PF_PROTO(PF_NETLINK, NETLINK_CONNECTOR);
static struct cn_dev cdev;
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] connector: add module alias
2010-12-09 17:36 [PATCH] connector: add module alias Stephen Hemminger
@ 2010-12-09 18:47 ` Evgeniy Polyakov
2010-12-10 20:28 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Evgeniy Polyakov @ 2010-12-09 18:47 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: netdev, davem
On Thu, Dec 09, 2010 at 09:36:46AM -0800, Stephen Hemminger (shemminger@vyatta.com) wrote:
> Since connector can be built as a module and uses netlink socket
> to communicate. The module should have an alias to autoload when socket
> of NETLINK_CONNECTOR type is requested.
Ack, thank you.
David, please apply.
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
>
> --- a/drivers/connector/connector.c 2010-12-09 09:19:05.549120343 -0800
> +++ b/drivers/connector/connector.c 2010-12-09 09:19:52.795051458 -0800
> @@ -36,6 +36,7 @@
> MODULE_LICENSE("GPL");
> MODULE_AUTHOR("Evgeniy Polyakov <zbr@ioremap.net>");
> MODULE_DESCRIPTION("Generic userspace <-> kernelspace connector.");
> +MODULE_ALIAS_NET_PF_PROTO(PF_NETLINK, NETLINK_CONNECTOR);
>
> static struct cn_dev cdev;
>
--
Evgeniy Polyakov
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] connector: add module alias
2010-12-09 18:47 ` Evgeniy Polyakov
@ 2010-12-10 20:28 ` David Miller
2010-12-10 20:44 ` Evgeniy Polyakov
0 siblings, 1 reply; 4+ messages in thread
From: David Miller @ 2010-12-10 20:28 UTC (permalink / raw)
To: zbr; +Cc: shemminger, netdev
From: Evgeniy Polyakov <zbr@ioremap.net>
Date: Thu, 9 Dec 2010 21:47:46 +0300
> On Thu, Dec 09, 2010 at 09:36:46AM -0800, Stephen Hemminger (shemminger@vyatta.com) wrote:
>> Since connector can be built as a module and uses netlink socket
>> to communicate. The module should have an alias to autoload when socket
>> of NETLINK_CONNECTOR type is requested.
>
> Ack, thank you.
Please use formalized "Acked-by: " tags so that the automated tools do
all the work for me and I don't have to type it in by hand.
> David, please apply.
Done, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] connector: add module alias
2010-12-10 20:28 ` David Miller
@ 2010-12-10 20:44 ` Evgeniy Polyakov
0 siblings, 0 replies; 4+ messages in thread
From: Evgeniy Polyakov @ 2010-12-10 20:44 UTC (permalink / raw)
To: David Miller; +Cc: shemminger, netdev
On Fri, Dec 10, 2010 at 12:28:13PM -0800, David Miller (davem@davemloft.net) wrote:
> >> Since connector can be built as a module and uses netlink socket
> >> to communicate. The module should have an alias to autoload when socket
> >> of NETLINK_CONNECTOR type is requested.
> >
> > Ack, thank you.
>
> Please use formalized "Acked-by: " tags so that the automated tools do
> all the work for me and I don't have to type it in by hand.
Will do, thanks.
--
Evgeniy Polyakov
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-12-10 20:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-09 17:36 [PATCH] connector: add module alias Stephen Hemminger
2010-12-09 18:47 ` Evgeniy Polyakov
2010-12-10 20:28 ` David Miller
2010-12-10 20:44 ` Evgeniy Polyakov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).