From: David Miller <davem@davemloft.net>
To: jon.mason@exar.com
Cc: netdev@vger.kernel.org, sivakumar.subramani@exar.com,
sreenivasa.honnur@exar.com, ram.vepa@exar.com
Subject: Re: [PATCH 1/4] s2io: rx_ring_sz bounds checking
Date: Sat, 11 Dec 2010 11:47:31 -0800 (PST) [thread overview]
Message-ID: <20101211.114731.104061835.davem@davemloft.net> (raw)
In-Reply-To: <1292031604-16628-1-git-send-email-jon.mason@exar.com>
From: Jon Mason <jon.mason@exar.com>
Date: Fri, 10 Dec 2010 19:40:01 -0600
> modparm rx_ring_sz can be set to be greater than the maximum allowable
> number of blocks. This results in an array overrun when probing the
> driver, and causes memory corruption.
>
> Also, the MAX_RX_DESC_1 multiply the max number of rings by max number
> of blocker per ring by 127, but the driver does the same calculation
> with 127+1. This results in the possibility of the value being set
> being larger than the maximum allowable value.
>
> Finally, clean-up the s2io_ethtool_gringparam code to be more
> intuitive.
>
> Signed-off-by: Jon Mason <jon.mason@exar.com>
Applied.
prev parent reply other threads:[~2010-12-11 19:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-11 1:40 [PATCH 1/4] s2io: rx_ring_sz bounds checking Jon Mason
2010-12-11 1:40 ` [PATCH 2/4] s2io: make strings at tables const Jon Mason
2010-12-11 19:47 ` David Miller
2010-12-11 1:40 ` [PATCH 3/4] s2io: Update Driver Version Jon Mason
2010-12-11 19:47 ` David Miller
2010-12-11 1:40 ` [PATCH 4/4] Using static const generally increases object text and decreases data size. It also generally decreases overall object size Jon Mason
2010-12-11 19:48 ` David Miller
2010-12-11 19:47 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101211.114731.104061835.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jon.mason@exar.com \
--cc=netdev@vger.kernel.org \
--cc=ram.vepa@exar.com \
--cc=sivakumar.subramani@exar.com \
--cc=sreenivasa.honnur@exar.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).