From: David Miller <davem@davemloft.net>
To: penguin-kernel@I-love.SAKURA.ne.jp
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org
Subject: Re: [2.6.37-rc5] Build error on parisc.
Date: Wed, 15 Dec 2010 10:19:25 -0800 (PST) [thread overview]
Message-ID: <20101215.101925.71116399.davem@davemloft.net> (raw)
In-Reply-To: <201012150801.oBF81EVm047830@www262.sakura.ne.jp>
From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Date: Wed, 15 Dec 2010 17:01:14 +0900
> [2.6.37-rc5] Build error on parisc.
>
> Commit 5635c10d "net: make sure struct dst_entry refcount is aligned on 64 bytes"
> uses manual padding. I triggered BUILD_BUG_ON() when using
> http://kernel.org/pub/tools/crosstool/files/bin/i686/4.5.1/i686-gcc-4.5.1-nolibc_hppa64-linux.tar.bz2 .
>
> make -s CROSS_COMPILE=hppa64-linux- ARCH=parisc
>
> include/net/dst.h: In function 'dst_hold':
> include/net/dst.h:161:2: error: negative width in bit-field '<anonymous>'
>
> I think below patch can fix the error but that commit says that we cannot use
> __atribute((aligned)). Why?
We don't want to create holes of unused space in the structure, we want
to know exactly how every byte of space is being used so nothing is
wasted when all features are enabed.
next prev parent reply other threads:[~2010-12-15 18:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-15 8:01 [2.6.37-rc5] Build error on parisc Tetsuo Handa
2010-12-15 18:19 ` David Miller [this message]
2010-12-15 18:22 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101215.101925.71116399.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox