From: Stephen Hemminger <shemminger@linux-foundation.org>
To: hadi@cyberus.ca
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
Changli Gao <xiaosuo@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Tom Herbert <therbert@google.com>, Jiri Pirko <jpirko@redhat.com>,
netdev@vger.kernel.org, netem@lists.linux-foundation.org
Subject: Re: |PATCH net-next-2.6] ifb: use netif_receive_skb() instead of netif_rx()
Date: Wed, 15 Dec 2010 08:14:47 -0800 [thread overview]
Message-ID: <20101215081447.64081885@nehalam> (raw)
In-Reply-To: <1292417363.2067.17.camel@mojatatu>
On Wed, 15 Dec 2010 07:49:23 -0500
jamal <hadi@cyberus.ca> wrote:
> On Wed, 2010-12-15 at 09:39 +0100, Eric Dumazet wrote:
> > In ri_tasklet(), we run from softirq, so can directly handle packet
> > through netif_receive_skb() instead of netif_rx().
> > There is no risk of recursion.
>
> Eric, did you do at least a simple test on this one?
> It used to be problematic (I cant remember why or
> what use case was problematic).
Only risk is stack overflow.
next prev parent reply other threads:[~2010-12-15 16:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-15 5:23 [PATCH 5/5 v2] net: add old_queue_mapping into skb->cb Changli Gao
2010-12-15 7:13 ` Eric Dumazet
2010-12-15 7:41 ` Changli Gao
2010-12-15 8:39 ` |PATCH net-next-2.6] ifb: use netif_receive_skb() instead of netif_rx() Eric Dumazet
2010-12-15 8:51 ` Changli Gao
2010-12-15 12:49 ` jamal
2010-12-15 14:21 ` Eric Dumazet
2010-12-17 12:55 ` jamal
2010-12-15 16:14 ` Stephen Hemminger [this message]
2010-12-15 16:19 ` [PATCH 5/5 v2] net: add old_queue_mapping into skb->cb Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101215081447.64081885@nehalam \
--to=shemminger@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=hadi@cyberus.ca \
--cc=jpirko@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=netem@lists.linux-foundation.org \
--cc=therbert@google.com \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).