* [PATCH net-next-2.6] vxge: add missing flush of reset_task
@ 2010-12-15 14:03 Tejun Heo
2010-12-15 14:29 ` Jon Mason
0 siblings, 1 reply; 3+ messages in thread
From: Tejun Heo @ 2010-12-15 14:03 UTC (permalink / raw)
To: David S. Miller, netdev@vger.kernel.org, lkml, jon.mason
Commit 6e07ebd84 (drivers/net: remove unnecessary
flush_scheduled_work() calls) incorrectly removed the flush call
without replacing it with the appropriate work specific operation.
Fix it by flushing vdev->reset_task explicitly.
Pointed out by Jon Mason.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Jon Mason <jon.mason@exar.com>
---
drivers/net/vxge/vxge-main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/vxge/vxge-main.c b/drivers/net/vxge/vxge-main.c
index 537ad87..1ac9b56 100644
--- a/drivers/net/vxge/vxge-main.c
+++ b/drivers/net/vxge/vxge-main.c
@@ -3439,6 +3439,8 @@ static void vxge_device_unregister(struct __vxge_hw_device *hldev)
strncpy(buf, dev->name, IFNAMSIZ);
+ flush_work_sync(&vdev->reset_task);
+
/* in 2.6 will call stop() if device is up */
unregister_netdev(dev);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next-2.6] vxge: add missing flush of reset_task
2010-12-15 14:03 [PATCH net-next-2.6] vxge: add missing flush of reset_task Tejun Heo
@ 2010-12-15 14:29 ` Jon Mason
2010-12-20 5:54 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Jon Mason @ 2010-12-15 14:29 UTC (permalink / raw)
To: Tejun Heo; +Cc: David S. Miller, netdev@vger.kernel.org, lkml
On Wed, Dec 15, 2010 at 06:03:29AM -0800, Tejun Heo wrote:
> Commit 6e07ebd84 (drivers/net: remove unnecessary
> flush_scheduled_work() calls) incorrectly removed the flush call
> without replacing it with the appropriate work specific operation.
> Fix it by flushing vdev->reset_task explicitly.
>
> Pointed out by Jon Mason.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Jon Mason <jon.mason@exar.com>
Acked-by: Jon Mason <jon.mason@exar.com>
> ---
> drivers/net/vxge/vxge-main.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/vxge/vxge-main.c b/drivers/net/vxge/vxge-main.c
> index 537ad87..1ac9b56 100644
> --- a/drivers/net/vxge/vxge-main.c
> +++ b/drivers/net/vxge/vxge-main.c
> @@ -3439,6 +3439,8 @@ static void vxge_device_unregister(struct __vxge_hw_device *hldev)
>
> strncpy(buf, dev->name, IFNAMSIZ);
>
> + flush_work_sync(&vdev->reset_task);
> +
> /* in 2.6 will call stop() if device is up */
> unregister_netdev(dev);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next-2.6] vxge: add missing flush of reset_task
2010-12-15 14:29 ` Jon Mason
@ 2010-12-20 5:54 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2010-12-20 5:54 UTC (permalink / raw)
To: jon.mason; +Cc: tj, netdev, linux-kernel
From: Jon Mason <jon.mason@exar.com>
Date: Wed, 15 Dec 2010 08:29:00 -0600
> On Wed, Dec 15, 2010 at 06:03:29AM -0800, Tejun Heo wrote:
>> Commit 6e07ebd84 (drivers/net: remove unnecessary
>> flush_scheduled_work() calls) incorrectly removed the flush call
>> without replacing it with the appropriate work specific operation.
>> Fix it by flushing vdev->reset_task explicitly.
>>
>> Pointed out by Jon Mason.
>>
>> Signed-off-by: Tejun Heo <tj@kernel.org>
>> Cc: Jon Mason <jon.mason@exar.com>
> Acked-by: Jon Mason <jon.mason@exar.com>
I'll apply this, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-12-20 5:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-15 14:03 [PATCH net-next-2.6] vxge: add missing flush of reset_task Tejun Heo
2010-12-15 14:29 ` Jon Mason
2010-12-20 5:54 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).