From: "Henry Ptasinski" <henryp@broadcom.com>
To: "Joe Perches" <joe@perches.com>
Cc: netdev <netdev@vger.kernel.org>,
"Brett Rudley" <brudley@broadcom.com>,
"Dowan Kim" <dowan@broadcom.com>,
"Arend Van Spriel" <arend@broadcom.com>,
"Roland Vossen" <rvossen@broadcom.com>
Subject: Re: [RFC PATCH net-next] if_ether.h: Add #define ETH_P_LARQ for HPNA/LARQ
Date: Wed, 15 Dec 2010 13:22:07 -0800 [thread overview]
Message-ID: <20101215212207.GA2548@broadcom.com> (raw)
In-Reply-To: <1292298831.26970.263.camel@Joe-Laptop>
On Mon, Dec 13, 2010 at 07:53:51PM -0800, Joe Perches wrote:
> On Mon, 2010-12-13 at 17:49 -0800, Henry Ptasinski wrote:
> > On Mon, Dec 13, 2010 at 04:47:47PM -0800, Joe Perches wrote:
> > > LARQ seems to be used by Broadcom's staging driver.
> > > Might as well add a #define for it to the normal location.
> > > diff --git a/include/linux/if_ether.h b/include/linux/if_ether.h
> []
> > > +#define ETH_P_LARQ 0x886c /* HPNA / Broadcom
> > That should be ETH_P_BRCM (or ETH_P_EPIGRAM). HPNA/ILCP used a range of
> > subtypes for LARQ and other HPNA protocols. The brcmfmac driver uses a
> > different subypte for encapsulating some event signals between the device and
> > the host, but doesn't implement any of the HPNA protocols.
>
> Another choice might be ETH_P_LINK_CTL
>
That would be fine too.
- Henry
next prev parent reply other threads:[~2010-12-15 21:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-14 0:47 [RFC PATCH net-next] if_ether.h: Add #define ETH_P_LARQ for HPNA/LARQ Joe Perches
2010-12-14 1:49 ` Henry Ptasinski
2010-12-14 3:53 ` Joe Perches
2010-12-15 21:22 ` Henry Ptasinski [this message]
2011-01-05 2:07 ` [PATCH] include/linux/if_ether.h: Add #define ETH_P_LINK_CTL for HPNA and wlan local tunnel Henry Ptasinski
2011-01-06 19:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101215212207.GA2548@broadcom.com \
--to=henryp@broadcom.com \
--cc=arend@broadcom.com \
--cc=brudley@broadcom.com \
--cc=dowan@broadcom.com \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
--cc=rvossen@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).