From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: dmitriy.balakin@nicneiron.ru, shemminger@vyatta.com,
netdev@vger.kernel.org
Subject: Re: [Bug 24842] New: Compatibility issue with uggly Windows RFC1323 implementation.
Date: Thu, 16 Dec 2010 14:08:51 -0800 (PST) [thread overview]
Message-ID: <20101216.140851.15238748.davem@davemloft.net> (raw)
In-Reply-To: <1292279462.2679.146.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 13 Dec 2010 23:31:02 +0100
> [PATCH net-next-2.6] tcp: relax tcp_paws_check()
>
> Some windows versions have wrong RFC1323 implementations, with SYN and
> SYNACKS messages containing zero tcp timestamps.
>
> We relaxed in commit fc1ad92dfc4e363 the passive connection case
> (Windows connects to a linux machine), but the reverse case (linux
> connects to a Windows machine) has an analogue problem when tsvals from
> windows machine are 'negative' (high order bit set) : PAWS triggers and
> we drops incoming messages.
>
> Fix this by making zero ts_recent value special, allowing frame to be
> processed.
>
> Based on a report and initial patch from Dmitiy Balakin
>
> Bugzilla reference : https://bugzilla.kernel.org/show_bug.cgi?id=24842
>
> Reported-by: dmitriy.balakin@nicneiron.ru
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied to net-next-2.6, thanks!
prev parent reply other threads:[~2010-12-16 22:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-13 16:59 Fw: [Bug 24842] New: Compatibility issue with uggly Windows RFC1323 implementation Stephen Hemminger
2010-12-13 17:14 ` Eric Dumazet
2010-12-13 20:44 ` Дмитрий Балакин
2010-12-13 22:31 ` Eric Dumazet
2010-12-14 0:35 ` Дмитрий Балакин
2010-12-16 22:08 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101216.140851.15238748.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dmitriy.balakin@nicneiron.ru \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).