From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: opurdila@ixiacom.com, netdev@vger.kernel.org,
lcrestez@ixiacom.com, stable@kernel.org
Subject: Re: [PATCH net-2.6 v2] net: fix nulls list corruptions in sk_prot_alloc
Date: Thu, 16 Dec 2010 14:16:00 -0800 (PST) [thread overview]
Message-ID: <20101216.141600.116387366.davem@davemloft.net> (raw)
In-Reply-To: <1292361811.2478.3.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 14 Dec 2010 22:23:31 +0100
> Le mardi 14 décembre 2010 à 19:19 +0200, Octavian Purdila a écrit :
>> Special care is taken inside sk_port_alloc to avoid overwriting
>> skc_node/skc_nulls_node. We should also avoid overwriting
>> skc_bind_node/skc_portaddr_node.
>>
>> The patch fixes the following crash:
>>
>> BUG: unable to handle kernel paging request at fffffffffffffff0
>> IP: [<ffffffff812ec6dd>] udp4_lib_lookup2+0xad/0x370
>> [<ffffffff812ecc22>] __udp4_lib_lookup+0x282/0x360
>> [<ffffffff812ed63e>] __udp4_lib_rcv+0x31e/0x700
>> [<ffffffff812bba45>] ? ip_local_deliver_finish+0x65/0x190
>> [<ffffffff812bbbf8>] ? ip_local_deliver+0x88/0xa0
>> [<ffffffff812eda35>] udp_rcv+0x15/0x20
>> [<ffffffff812bba45>] ip_local_deliver_finish+0x65/0x190
>> [<ffffffff812bbbf8>] ip_local_deliver+0x88/0xa0
>> [<ffffffff812bb2cd>] ip_rcv_finish+0x32d/0x6f0
>> [<ffffffff8128c14c>] ? netif_receive_skb+0x99c/0x11c0
>> [<ffffffff812bb94b>] ip_rcv+0x2bb/0x350
>> [<ffffffff8128c14c>] netif_receive_skb+0x99c/0x11c0
>>
>> Signed-off-by: Leonard Crestez <lcrestez@ixiacom.com>
>> Signed-off-by: Octavian Purdila <opurdila@ixiacom.com>
>> Cc: Eric Dumazet <eric.dumazet@gmail.com>
>> Cc: stable@kernel.org
>> ---
>
> Thanks Octavian !
>
> Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks everyone.
prev parent reply other threads:[~2010-12-16 22:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-14 17:19 [PATCH net-2.6 v2] net: fix nulls list corruptions in sk_prot_alloc Octavian Purdila
2010-12-14 21:23 ` Eric Dumazet
2010-12-16 22:16 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101216.141600.116387366.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=lcrestez@ixiacom.com \
--cc=netdev@vger.kernel.org \
--cc=opurdila@ixiacom.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).