netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] fix IPv6 queries for bridge multicast snooping
@ 2010-12-14 18:42 David L Stevens
  2010-12-15  1:00 ` Herbert Xu
  0 siblings, 1 reply; 3+ messages in thread
From: David L Stevens @ 2010-12-14 18:42 UTC (permalink / raw)
  To: Herbert Xu, davem; +Cc: netdev

This patch fixes a missing ntohs() for bridge IPv6 multicast snooping.

Signed-off-by: David L Stevens <dlstevens@us.ibm.com>

--- linux-2.6.37-rc5/net/bridge/br_multicast.c	2010-12-06 20:09:04.000000000 -0800
+++ linux-2.6.37-rc5DLS/net/bridge/br_multicast.c	2010-12-13 14:55:34.228196279 -0800
@@ -437,7 +437,7 @@ static struct sk_buff *br_ip6_multicast_
 	ip6h = ipv6_hdr(skb);
 
 	*(__force __be32 *)ip6h = htonl(0x60000000);
-	ip6h->payload_len = 8 + sizeof(*mldq);
+	ip6h->payload_len = htons(8 + sizeof(*mldq));
 	ip6h->nexthdr = IPPROTO_HOPOPTS;
 	ip6h->hop_limit = 1;
 	ipv6_addr_set(&ip6h->saddr, 0, 0, 0, 0);




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] fix IPv6 queries for bridge multicast snooping
  2010-12-14 18:42 [PATCH] fix IPv6 queries for bridge multicast snooping David L Stevens
@ 2010-12-15  1:00 ` Herbert Xu
  2010-12-16 22:17   ` David Miller
  0 siblings, 1 reply; 3+ messages in thread
From: Herbert Xu @ 2010-12-15  1:00 UTC (permalink / raw)
  To: David L Stevens; +Cc: davem, netdev

On Tue, Dec 14, 2010 at 10:42:16AM -0800, David L Stevens wrote:
> This patch fixes a missing ntohs() for bridge IPv6 multicast snooping.
> 
> Signed-off-by: David L Stevens <dlstevens@us.ibm.com>

Acked-by: Herbert Xu <herbert@gondor.apana.org.au>

I had wanted to fix this but forgot :)

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] fix IPv6 queries for bridge multicast snooping
  2010-12-15  1:00 ` Herbert Xu
@ 2010-12-16 22:17   ` David Miller
  0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2010-12-16 22:17 UTC (permalink / raw)
  To: herbert; +Cc: dlstevens, davem, netdev

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Wed, 15 Dec 2010 09:00:50 +0800

> On Tue, Dec 14, 2010 at 10:42:16AM -0800, David L Stevens wrote:
>> This patch fixes a missing ntohs() for bridge IPv6 multicast snooping.
>> 
>> Signed-off-by: David L Stevens <dlstevens@us.ibm.com>
> 
> Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
> 
> I had wanted to fix this but forgot :)

Applied and queued up for -stable, thanks!

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-12-16 22:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-14 18:42 [PATCH] fix IPv6 queries for bridge multicast snooping David L Stevens
2010-12-15  1:00 ` Herbert Xu
2010-12-16 22:17   ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).