* [PATCH] sctp: fix the return value of getting the sctp partial delivery point
@ 2010-12-15 2:10 Wei Yongjun
2010-12-15 15:53 ` Vladislav Yasevich
0 siblings, 1 reply; 3+ messages in thread
From: Wei Yongjun @ 2010-12-15 2:10 UTC (permalink / raw)
To: Vlad Yasevich, David Miller; +Cc: linux-sctp, netdev@vger.kernel.org
Get the sctp partial delivery point using SCTP_PARTIAL_DELIVERY_POINT
socket option should return 0 if success, not -ENOTSUPP.
Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
---
net/sctp/socket.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/sctp/socket.c b/net/sctp/socket.c
index 1bc5203..8628e8e 100644
--- a/net/sctp/socket.c
+++ b/net/sctp/socket.c
@@ -5050,7 +5050,7 @@ static int sctp_getsockopt_partial_delivery_point(struct sock *sk, int len,
if (copy_to_user(optval, &val, len))
return -EFAULT;
- return -ENOTSUPP;
+ return 0;
}
/*
--
1.6.5.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] sctp: fix the return value of getting the sctp partial delivery point
2010-12-15 2:10 [PATCH] sctp: fix the return value of getting the sctp partial delivery point Wei Yongjun
@ 2010-12-15 15:53 ` Vladislav Yasevich
2010-12-16 22:49 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Vladislav Yasevich @ 2010-12-15 15:53 UTC (permalink / raw)
To: Wei Yongjun; +Cc: David Miller, linux-sctp, netdev@vger.kernel.org
On 12/14/2010 09:10 PM, Wei Yongjun wrote:
> Get the sctp partial delivery point using SCTP_PARTIAL_DELIVERY_POINT
> socket option should return 0 if success, not -ENOTSUPP.
>
Ack.
-vlad
> Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
> ---
> net/sctp/socket.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/sctp/socket.c b/net/sctp/socket.c
> index 1bc5203..8628e8e 100644
> --- a/net/sctp/socket.c
> +++ b/net/sctp/socket.c
> @@ -5050,7 +5050,7 @@ static int sctp_getsockopt_partial_delivery_point(struct sock *sk, int len,
> if (copy_to_user(optval, &val, len))
> return -EFAULT;
>
> - return -ENOTSUPP;
> + return 0;
> }
>
> /*
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sctp: fix the return value of getting the sctp partial delivery point
2010-12-15 15:53 ` Vladislav Yasevich
@ 2010-12-16 22:49 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2010-12-16 22:49 UTC (permalink / raw)
To: vladislav.yasevich; +Cc: yjwei, linux-sctp, netdev
From: Vladislav Yasevich <vladislav.yasevich@hp.com>
Date: Wed, 15 Dec 2010 10:53:14 -0500
> On 12/14/2010 09:10 PM, Wei Yongjun wrote:
>> Get the sctp partial delivery point using SCTP_PARTIAL_DELIVERY_POINT
>> socket option should return 0 if success, not -ENOTSUPP.
>>
>
> Ack.
>
> -vlad
>
>> Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Applied, thanks everyone.
Vlad, please use properly formed full "Acked-by: ..." in the
future otherwise automated tools don't pick it up and it's
therefore more likely your ACK gets lost.
Thanks :-)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-12-16 22:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-15 2:10 [PATCH] sctp: fix the return value of getting the sctp partial delivery point Wei Yongjun
2010-12-15 15:53 ` Vladislav Yasevich
2010-12-16 22:49 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).