From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: [RFC] ipv6: don't flush routes when setting loopback down Date: Thu, 16 Dec 2010 13:28:12 -0800 Message-ID: <20101216132812.2d7fd885@nehalam> References: <4D00F58A.2050307@hp.com> <20101209111611.1d2e6e2b@nehalam> <20101209.122033.183046393.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: ebiederm@xmission.com, brian.haley@hp.com, netdev@vger.kernel.org, maheshkelkar@gmail.com, lorenzo@google.com, yoshfuji@linux-ipv6.org, stable@kernel.org To: David Miller Return-path: Received: from mail.vyatta.com ([76.74.103.46]:45922 "EHLO mail.vyatta.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752078Ab0LPV2P (ORCPT ); Thu, 16 Dec 2010 16:28:15 -0500 In-Reply-To: <20101209.122033.183046393.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: When loopback device is being brought down, then keep the route table entries because they are special. The entries in the local table for linklocal routes and ::1 address should not be purged. This is a sub optimal solution to the problem and should be replaced by a better fix in future. Signed-off-by: Stephen Hemminger --- patch versus current net-next tree, but if this acceptable it should be applied to net-2.6 as well. --- a/net/ipv6/addrconf.c 2010-12-16 10:29:34.035408392 -0800 +++ b/net/ipv6/addrconf.c 2010-12-16 10:30:37.366834482 -0800 @@ -2669,7 +2669,9 @@ static int addrconf_ifdown(struct net_de ASSERT_RTNL(); - rt6_ifdown(net, dev); + /* Flush routes if device is being removed or it is not loopback */ + if (how || !(dev->flags & IFF_LOOPBACK)) + rt6_ifdown(net, dev); neigh_ifdown(&nd_tbl, dev); idev = __in6_dev_get(dev);