From: Stephen Hemminger <shemminger@vyatta.com>
To: Jay Vosburgh <fubar@us.ibm.com>
Cc: netdev@vger.kernel.org, Andy Gospodarek <andy@greyhouse.net>
Subject: Re: [PATCH v2 1/2] bonding: generic netlink infrastructure
Date: Thu, 16 Dec 2010 15:12:07 -0800 [thread overview]
Message-ID: <20101216151207.3ead4c21@nehalam> (raw)
In-Reply-To: <1292540003-9465-2-git-send-email-fubar@us.ibm.com>
On Thu, 16 Dec 2010 14:53:22 -0800
Jay Vosburgh <fubar@us.ibm.com> wrote:
> Generic netlink infrastructure for bonding. Includes two
> netlink operations: notification for slave link state change, and a
> "get mode" netlink command.
> ---
1. The printk() for error needs to either be dropped or turned into
a real loggable message (ie add more info and printk level).
2. Don't use C99 comments to comment out stuff
3. checkpatch has other whitespace complaints.
4. Missing Signed-off-by:
--
next prev parent reply other threads:[~2010-12-16 23:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-16 22:53 [RFC v2 PATCH 0/2] bonding: generic netlink, multi-link mode Jay Vosburgh
2010-12-16 22:53 ` [PATCH v2 1/2] bonding: generic netlink infrastructure Jay Vosburgh
2010-12-16 23:12 ` Stephen Hemminger [this message]
2010-12-16 22:53 ` [PATCH v2 2/2] bonding: add multi-link mode Jay Vosburgh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101216151207.3ead4c21@nehalam \
--to=shemminger@vyatta.com \
--cc=andy@greyhouse.net \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).