Re: pktgen IP address stepping

[Kristian Larsson <kristian@spritelink.net>]

On Thu, Dec 16, 2010 at 10:02:12AM -0800, Joe Perches wrote:
> On Thu, 2010-12-16 at 18:28 +0100, Kristian Larsson wrote:
> > This patch adds the ability to set the step rate at which the source
> > or destination IP address is increased when src_min / src_max or
> > dst_min / dst_max is used with pktgen.
> > Usage is simple, two new parameters:
> >   src_step X
> >   dst_step X
> > where X is a positive integer (or actually an unsigned long long).
> []
> > Looking forward to any feedback and / or suggestions.
> 
> I suggest using actual ipv4 addresses (and ipv6 if you ever
> need it) as increment/mask.

Not sure I follow you, should the stepping be specified as
0.0.0.213 if I would like to increase with 213 or 0.0.255.255 if
I want to increase by a /16 at a time?

> For your current use, __u32 would work fine.

Yepp, I'll have a look at that once I get home :)
 

> trivia:
> 
> pr_<foo> calls are already prefixed with pktgen via pr_fmt,
> you don't need to add it to the format string.

Same thing here, will look over it. I think I copied most of this
from some other part of pktgen.c :)

Kind regards,
    Kristian.

-- 
Kristian Larsson                                        KLL-RIPE
+46 704 264511			                      kll@spritelink.net