From: Kristian Larsson <kristian@spritelink.net>
To: Joe Perches <joe@perches.com>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: pktgen IP address stepping
Date: Thu, 16 Dec 2010 22:11:54 +0100 [thread overview]
Message-ID: <20101216211153.GA8658@spritelink.se> (raw)
In-Reply-To: <1292522532.29894.33.camel@Joe-Laptop>
On Thu, Dec 16, 2010 at 10:02:12AM -0800, Joe Perches wrote:
> pr_<foo> calls are already prefixed with pktgen via pr_fmt,
> you don't need to add it to the format string.
I can see at least two different cases of debug statements;
if (debug)
pr_info("Delay set at: %llu ns\n", pkt_dev->delay);
if (debug)
printk(KERN_DEBUG "pktgen: dst_min set to: %s\n",
pkt_dev->dst_min);
what's the reasoning behind using one or the other?
-K
--
Kristian Larsson KLL-RIPE
+46 704 264511 kll@spritelink.net
next prev parent reply other threads:[~2010-12-16 21:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-16 17:28 pktgen IP address stepping Kristian Larsson
2010-12-16 17:44 ` David Miller
2010-12-16 18:27 ` Kristian Larsson
2010-12-16 18:34 ` David Miller
2010-12-16 18:02 ` Joe Perches
2010-12-16 18:30 ` Kristian Larsson
2010-12-16 19:02 ` [PATCH net-next] pktgen: Remove unnecessary prefix from pr_<level> Joe Perches
2010-12-20 18:30 ` David Miller
2010-12-16 19:18 ` pktgen IP address stepping Joe Perches
2010-12-16 20:34 ` Kristian Larsson
2010-12-16 21:11 ` Kristian Larsson [this message]
2010-12-16 21:22 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101216211153.GA8658@spritelink.se \
--to=kristian@spritelink.net \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).