From: Jarek Poplawski <jarkao2@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>,
Changli Gao <xiaosuo@gmail.com>, netdev <netdev@vger.kernel.org>,
Patrick McHardy <kaber@trash.net>
Subject: Re: [PATCH net-next-2.6] net: force a fresh timestamp for ingress packets
Date: Thu, 16 Dec 2010 23:42:37 +0100 [thread overview]
Message-ID: <20101216224237.GC2191@del.dom.local> (raw)
In-Reply-To: <1292538363.2655.20.camel@edumazet-laptop>
On Thu, Dec 16, 2010 at 11:26:03PM +0100, Eric Dumazet wrote:
> Le jeudi 16 décembre 2010 ?? 23:08 +0100, Jarek Poplawski a écrit :
>
> > Hmm... Do you expect more people start debugging SFQ or I missed your
> > point? ;-) Maybe such a change would be reasonable on a cloned skb?
>
> My point was to permit an admin to check his ingress shaping works or
> not. In this respect, netem was a specialization of a general problem.
>
> We had a prior discussion on timestamping skb in RX path, when RPS came
> in : Should we take timestamp before RPS or after. At that time we added
> a sysctl. Not sure it was the right choice :-(
>
> I feel tcpdump (on TX side) should really display time of packet right
> before being given to device, but this is probably a matter of taste.
It might be reasonable unless it changes data for later users. That's
why I mentioned cloning.
>
> Before commit 8caf153974f2 (net: sch_netem: Fix an inconsistency in
> ingress netem timestamps.), this is what was done.
Then why don't you try to let turn it off in netem, where it only
matters?
Jarek P.
next prev parent reply other threads:[~2010-12-16 22:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-15 15:50 [PATCH net-next-2.6] net: force a fresh timestamp for ingress packets Eric Dumazet
2010-12-16 21:17 ` Jarek Poplawski
2010-12-16 21:30 ` Eric Dumazet
2010-12-16 22:08 ` Jarek Poplawski
2010-12-16 22:26 ` Eric Dumazet
2010-12-16 22:42 ` Jarek Poplawski [this message]
2010-12-16 23:31 ` Eric Dumazet
2010-12-17 7:30 ` Jarek Poplawski
2010-12-17 8:08 ` Eric Dumazet
2010-12-17 8:34 ` Jarek Poplawski
2010-12-17 8:59 ` Jarek Poplawski
2010-12-17 9:26 ` Eric Dumazet
2010-12-21 7:22 ` [PATCH net-next-2.6] net: timestamp cloned packet in dev_queue_xmit_nit Eric Dumazet
2010-12-21 7:56 ` Changli Gao
2010-12-21 18:50 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101216224237.GC2191@del.dom.local \
--to=jarkao2@gmail.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).