From: David Miller <davem@davemloft.net>
To: alexander.h.duyck@intel.com
Cc: netdev@vger.kernel.org
Subject: Re: [RFC PATCH 3/3] igb: example of how to update igb to make use of in-kernel Toeplitz hashing
Date: Fri, 17 Dec 2010 21:09:23 -0800 (PST) [thread overview]
Message-ID: <20101217.210923.193721885.davem@davemloft.net> (raw)
In-Reply-To: <20101218010048.28602.49776.stgit@gitlad.jf.intel.com>
From: Alexander Duyck <alexander.h.duyck@intel.com>
Date: Fri, 17 Dec 2010 17:00:48 -0800
> @@ -1691,6 +1692,7 @@ static const struct net_device_ops igb_netdev_ops = {
> .ndo_open = igb_open,
> .ndo_stop = igb_close,
> .ndo_start_xmit = igb_xmit_frame_adv,
> + .ndo_select_queue = toeplitz_select_queue,
> .ndo_get_stats64 = igb_get_stats64,
> .ndo_set_rx_mode = igb_set_rx_mode,
> .ndo_set_multicast_list = igb_set_rx_mode,
Adding a NETIF_F_TX_TOEPLITZ flag that skb_tx_hash() keys off of would
be a lot simpler.
We want less overriding of ->ndo_select_queue(), not more, and this case
is definitely gratuitous.
next prev parent reply other threads:[~2010-12-18 5:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-18 1:00 [RFC PATCH 0/3] Simplified 16 bit Toeplitz hash algorithm Alexander Duyck
2010-12-18 1:00 ` [RFC PATCH 1/3] net: add simplified 16 bit Toeplitz hash function for transmit side hashing Alexander Duyck
2010-12-18 1:00 ` [RFC PATCH 2/3] ixgbe: example of how to update ixgbe to make use of in-kernel Toeplitz hash Alexander Duyck
2010-12-18 1:00 ` [RFC PATCH 3/3] igb: example of how to update igb to make use of in-kernel Toeplitz hashing Alexander Duyck
2010-12-18 5:09 ` David Miller [this message]
2010-12-18 6:53 ` Alexander Duyck
2010-12-18 6:59 ` David Miller
2011-01-03 18:47 ` [RFC PATCH 0/3] Simplified 16 bit Toeplitz hash algorithm Tom Herbert
2011-01-03 19:00 ` Alexander Duyck
2011-01-03 19:02 ` David Miller
2011-01-03 19:30 ` Ben Hutchings
2011-01-03 19:52 ` Alexander Duyck
2011-01-03 19:54 ` David Miller
2011-01-03 20:15 ` Ben Hutchings
2011-01-03 21:45 ` Alexander Duyck
2011-01-04 3:25 ` Tom Herbert
2011-01-04 15:43 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101217.210923.193721885.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexander.h.duyck@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).