From: David Miller <davem@davemloft.net>
To: nanditad@google.com
Cc: netdev@vger.kernel.org, therbert@google.com, chavey@google.com,
ycheng@google.com
Subject: Re: [PATCH 1/1] TCP: increase default initial receive window.
Date: Fri, 17 Dec 2010 21:13:09 -0800 (PST) [thread overview]
Message-ID: <20101217.211309.226761639.davem@davemloft.net> (raw)
In-Reply-To: <1292642451-892-1-git-send-email-nanditad@google.com>
From: Nandita Dukkipati <nanditad@google.com>
Date: Fri, 17 Dec 2010 19:20:51 -0800
> This patch changes the default initial receive window to 10 mss
> (defined constant). The default window is limited to the maximum
> of 10*1460 and 2*mss (when mss > 1460).
>
> Signed-off-by: Nandita Dukkipati <nanditad@google.com>
That's an incredibly terse explanation for a very non-trivial
change with very non-trivial implications.
What analysis have you performed to lead you to decide that this
was a reasonable change to make? Where can people see that
analysis and look over it to see if they agree with your
assesment of the data?
We can't apply a patch like that without any form of analysis or
reasoning.
You don't say "why" you're doing this, and frankly that really
ticks me off.
next prev parent reply other threads:[~2010-12-18 5:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-18 3:20 [PATCH 1/1] TCP: increase default initial receive window Nandita Dukkipati
2010-12-18 3:59 ` Stephen Hemminger
2010-12-18 5:14 ` David Miller
2010-12-18 5:13 ` David Miller [this message]
2010-12-18 9:08 ` Nandita Dukkipati
2010-12-20 17:03 ` Stephen Hemminger
2010-12-20 18:26 ` Rick Jones
2010-12-20 18:48 ` David Miller
2010-12-21 0:15 ` [PATCH v2 " Nandita Dukkipati
2010-12-21 0:23 ` Nandita Dukkipati
2010-12-21 5:00 ` Eric Dumazet
2010-12-21 5:33 ` David Miller
2010-12-21 18:27 ` [PATCH " John Heffner
2010-12-21 18:49 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101217.211309.226761639.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=chavey@google.com \
--cc=nanditad@google.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).