From: Stephen Hemminger <shemminger@vyatta.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: netdev <netdev@vger.kernel.org>, davem@davemloft.net
Subject: Re: [PATCH] dev_alloc_name: fix kernel-doc formatting, typos, etc.
Date: Fri, 17 Dec 2010 13:53:55 -0800 [thread overview]
Message-ID: <20101217135355.1f88ffff@nehalam> (raw)
In-Reply-To: <20101217134046.61eb94dd.randy.dunlap@oracle.com>
On Fri, 17 Dec 2010 13:40:46 -0800
Randy Dunlap <randy.dunlap@oracle.com> wrote:
> - * Passed a format string - eg "lt%d" it will try and find a suitable
> + * Passed a format string - e.g. "lt%%d", it will try to find a suitable
This is wrong.
The obvious case of:
alloc_etherdev() ends up calling __dev_alloc_name with "eth%d"
in fact __dev_alloc_name called with "lt%%d" will return -EINVAL
--
next prev parent reply other threads:[~2010-12-17 21:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-17 21:40 [PATCH] dev_alloc_name: fix kernel-doc formatting, typos, etc Randy Dunlap
2010-12-17 21:53 ` Stephen Hemminger [this message]
2010-12-17 22:00 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101217135355.1f88ffff@nehalam \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).