From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: [PATCH] dev_alloc_name: fix kernel-doc formatting, typos, etc. Date: Fri, 17 Dec 2010 14:00:30 -0800 Message-ID: <20101217140030.9ca81cd2.randy.dunlap@oracle.com> References: <20101217134046.61eb94dd.randy.dunlap@oracle.com> <20101217135355.1f88ffff@nehalam> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev , davem@davemloft.net To: Stephen Hemminger Return-path: Received: from rcsinet10.oracle.com ([148.87.113.121]:33762 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756640Ab0LQWAq (ORCPT ); Fri, 17 Dec 2010 17:00:46 -0500 In-Reply-To: <20101217135355.1f88ffff@nehalam> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 17 Dec 2010 13:53:55 -0800 Stephen Hemminger wrote: > On Fri, 17 Dec 2010 13:40:46 -0800 > Randy Dunlap wrote: > > > - * Passed a format string - eg "lt%d" it will try and find a suitable > > + * Passed a format string - e.g. "lt%%d", it will try to find a suitable > > This is wrong. > The obvious case of: > alloc_etherdev() ends up calling __dev_alloc_name with "eth%d" > in fact __dev_alloc_name called with "lt%%d" will return -EINVAL OK, thanks. I'll see if a tool fix is possible. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***