From: Denys Fedoryshchenko <nuclearcat@nuclearcat.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: Octavian Purdila <opurdila@ixiacom.com>,
netdev@vger.kernel.org,
Lucian Adrian Grijincu <lucian.grijincu@gmail.com>,
Vlad Dogaru <ddvlad@rosedu.org>
Subject: Re: [PATCH] iproute2: initialize the ll_map only once
Date: Fri, 17 Dec 2010 15:06:41 +0200 [thread overview]
Message-ID: <201012171506.41834.nuclearcat@nuclearcat.com> (raw)
In-Reply-To: <20101210113809.56ea259e@nehalam>
On Friday 10 December 2010 21:38:09 Stephen Hemminger wrote:
> On Fri, 10 Dec 2010 16:59:50 +0200
>
> Octavian Purdila <opurdila@ixiacom.com> wrote:
> > Avoid initializing the LL map (which involves a costly RTNL dump)
> > multiple times. This can happen when running in batch mode.
> >
> > Signed-off-by: Octavian Purdila <opurdila@ixiacom.com>
>
> applied
There is some longstanding bug related to current hashing system.
To "workaround" it i did my own "flush" command, to flush hashes, but with
this patch it becomes more difficult to handle this situation.
Here is how to reproduce it:
ip -force -batch -
link add link eth0 name new0 type macvlan
link show dev new0
link delete dev new0 type macvlan
link add link eth0 name new0 type macvlan
link show dev new0
Last command will not show link, because index of old one is stored in hash.
I guess it is more bugreport for old problem, than problem with current patch.
Sure it is possible to flush hash on del/add operations, but additionally
during batch run it is possible that interfaces can appear/disappear (NAS with
thousands of ppp interfaces). Maybe still as an idea i can do patch with flag
to dump rtnl before each command and additional "flush hash" command?
prev parent reply other threads:[~2010-12-17 13:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-10 14:59 [PATCH] iproute2: initialize the ll_map only once Octavian Purdila
2010-12-10 19:38 ` Stephen Hemminger
2010-12-17 13:06 ` Denys Fedoryshchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201012171506.41834.nuclearcat@nuclearcat.com \
--to=nuclearcat@nuclearcat.com \
--cc=ddvlad@rosedu.org \
--cc=lucian.grijincu@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=opurdila@ixiacom.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).