From: David Miller <davem@davemloft.net>
To: shanwei@cn.fujitsu.com
Cc: albertpretorius@yahoo.co.uk, netdev@vger.kernel.org,
yoshfuji@linux-ipv6.org, pekkas@netcore.fi, jmorris@namei.org
Subject: Re: IPV6 loopback bound socket succeeds connecting to remote host
Date: Sun, 19 Dec 2010 22:43:50 -0800 (PST) [thread overview]
Message-ID: <20101219.224350.260095315.davem@davemloft.net> (raw)
In-Reply-To: <4D0EF840.2020108@cn.fujitsu.com>
From: Shan Wei <shanwei@cn.fujitsu.com>
Date: Mon, 20 Dec 2010 14:31:28 +0800
> David Miller wrote, at 12/17/2010 04:18 AM:
>> Your approach will only modify socket based route handling, it will
>> not handle the ipv6 forwarding case which as per the quoted RFC
>> sections must be handled too.
>
> For the ipv6 forwarding case, we have done the check in ip6_forward().
>
> 493 int addrtype = ipv6_addr_type(&hdr->saddr);
> 494
> 495 /* This check is security critical. */
> 496 if (addrtype == IPV6_ADDR_ANY ||
> 497 addrtype & (IPV6_ADDR_MULTICAST | IPV6_ADDR_LOOPBACK))
> 498 goto error;
Indeed, thanks for pointing this out.
next prev parent reply other threads:[~2010-12-20 6:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-29 10:55 IPV6 loopback bound socket succeeds connecting to remote host Albert Pretorius
2010-12-01 8:18 ` Shan Wei
2010-12-02 7:45 ` Albert Pretorius
2010-12-02 8:41 ` Shan Wei
2010-12-16 20:18 ` David Miller
2010-12-20 6:31 ` Shan Wei
2010-12-20 6:43 ` David Miller [this message]
2010-12-22 7:06 ` Shan Wei
2010-12-29 16:53 ` Albert Pretorius
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101219.224350.260095315.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=albertpretorius@yahoo.co.uk \
--cc=jmorris@namei.org \
--cc=netdev@vger.kernel.org \
--cc=pekkas@netcore.fi \
--cc=shanwei@cn.fujitsu.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).