From: Jarek Poplawski <jarkao2@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Changli Gao <xiaosuo@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Jamal Hadi Salim <hadi@cyberus.ca>,
Pawel Staszewski <pstaszewski@itcare.pl>
Subject: Re: [PATCH net-2.6] net_sched: always clone skbs
Date: Tue, 21 Dec 2010 00:52:09 +0100 [thread overview]
Message-ID: <20101220235209.GA1865@del.dom.local> (raw)
In-Reply-To: <1292887689.2627.150.camel@edumazet-laptop>
On Tue, Dec 21, 2010 at 12:28:09AM +0100, Eric Dumazet wrote:
> Le mardi 21 décembre 2010 ?? 00:20 +0100, Jarek Poplawski a écrit :
> > On Mon, Dec 20, 2010 at 10:35:30PM +0800, Changli Gao wrote:
> > > Pawel reported a panic related to handling shared skbs in ixgbe
> > > incorrectly. So we need to revert my previous patch to work around
> > > this bug. Instead of reverting the patch completely, I just revert
> > > the essential lines, so we can add the previous optimization
> > > back more easily in future.
> > >
> > > commit 3511c9132f8b1e1b5634e41a3331c44b0c13be70
> > > Author: Changli Gao <xiaosuo@gmail.com>
> > > Date: Sat Oct 16 13:04:08 2010 +0000
> > >
> > > net_sched: remove the unused parameter of qdisc_create_dflt()
> > >
> >
> > Isn't there some mistake in the commit number? IMHO this changelog is
> > mostly wrong. The bug happens outside of ixgbe, probably in
> > dev_hard_start_xmit() -> __skb_linearize(), and even if not, it can,
> > without any driver's fault. The only question is why it didn't triger
> > with 2.6.36.
> >
>
> Indeed, commit number is wrong. It was :
>
> commit 210d6de78c5d7c785fc532556cea340e517955e1
> Author: Changli Gao <xiaosuo@gmail.com>
> Date: Thu Jun 24 16:25:12 2010 +0000
>
> act_mirred: don't clone skb when skb isn't shared
>
> It triggers now because GRO might be default to on now.
>
> commit 6a08d194ee40806e0ccd5f36ed768e64cbfc979f
> e1000: use GRO for receive
>
> (or other various GRO patches)
Well, still some doubt after re-reading Pawel's 1st. message:
host1 (kernel 2.6.36.2)
netperf client -> eth3 (82598EB 10-Gigabit AT CX4) - directly connected to eth2 of host2
ethtool -k eth3
Offload parameters for eth3:
rx-checksumming: on
tx-checksumming: on
scatter-gather: on
tcp-segmentation-offload: on
udp-fragmentation-offload: off
generic-segmentation-offload: on
generic-receive-offload: on
...
Of course, I know this was another box.
Jarek P.
next prev parent reply other threads:[~2010-12-20 23:52 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-20 14:35 [PATCH net-2.6] net_sched: always clone skbs Changli Gao
2010-12-20 14:37 ` Eric Dumazet
2010-12-20 18:27 ` David Miller
2010-12-20 23:20 ` Jarek Poplawski
2010-12-20 23:28 ` Eric Dumazet
2010-12-20 23:52 ` Jarek Poplawski [this message]
2010-12-21 13:52 ` jamal
2010-12-21 14:17 ` Changli Gao
2010-12-21 22:37 ` Jarek Poplawski
2010-12-23 13:35 ` jamal
2010-12-23 23:04 ` Jarek Poplawski
2011-01-02 21:27 ` [RFC] net_sched: mark packet staying on queue too long Eric Dumazet
2011-01-03 13:52 ` jamal
2011-01-03 14:02 ` Eric Dumazet
2011-01-03 15:02 ` jamal
2011-01-03 18:11 ` [PATCH] sch_red: report backlog information Eric Dumazet
2011-01-03 20:13 ` David Miller
2011-01-03 17:58 ` [RFC] net_sched: mark packet staying on queue too long Stephen Hemminger
2011-01-04 14:19 ` Jesper Dangaard Brouer
2011-01-04 15:02 ` Eric Dumazet
2011-01-04 16:05 ` Stephen Hemminger
2011-01-04 18:20 ` Eric Dumazet
2011-01-04 18:29 ` Eric Dumazet
2011-01-13 11:50 ` Patrick McHardy
2011-01-13 15:54 ` Eric Dumazet
2011-01-13 16:04 ` sch_sfb [was: net_sched: mark packet staying on queue too long] Juliusz Chroboczek
2011-01-13 18:59 ` Patrick McHardy
2011-01-14 0:59 ` sch_sfb Juliusz Chroboczek
2011-01-14 1:39 ` sch_sfb Patrick McHardy
2011-01-14 13:34 ` sch_sfb Juliusz Chroboczek
2011-01-14 13:37 ` sch_sfb Patrick McHardy
2011-01-14 15:09 ` sch_sfb Eric Dumazet
2011-01-14 21:06 ` sch_sfb Jarek Poplawski
2010-12-21 0:21 ` [PATCH net-2.6] net_sched: always clone skbs Changli Gao
2010-12-21 3:55 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101220235209.GA1865@del.dom.local \
--to=jarkao2@gmail.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=hadi@cyberus.ca \
--cc=netdev@vger.kernel.org \
--cc=pstaszewski@itcare.pl \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).