From: David Miller <davem@davemloft.net>
To: eilong@broadcom.com
Cc: error27@gmail.com, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch -next] bnx2x: remove bogus check
Date: Tue, 21 Dec 2010 10:51:48 -0800 (PST) [thread overview]
Message-ID: <20101221.105148.71131041.davem@davemloft.net> (raw)
In-Reply-To: <1292939316.21210.7084.camel@lb-tlvb-eilong.il.broadcom.com>
From: "Eilon Greenstein" <eilong@broadcom.com>
Date: Tue, 21 Dec 2010 15:48:36 +0200
> On Mon, 2010-12-20 at 23:04 -0800, Dan Carpenter wrote:
>> We dereferenced params on the line before so it's too late to check if
>> params is NULL. In fact, params can never be NULL and strict_cos is
>> either 0 or 1 so that part of the check is bogus too. Let's remove it.
>>
>> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> Thanks Dan!
>
> Acked-by: Eilon Greenstein <eilong@broadcom.com>
Applied, thanks everyone.
prev parent reply other threads:[~2010-12-21 18:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-21 7:04 [patch -next] bnx2x: remove bogus check Dan Carpenter
2010-12-21 13:48 ` Eilon Greenstein
2010-12-21 18:51 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101221.105148.71131041.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eilong@broadcom.com \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).