From: David Miller <davem@davemloft.net>
To: error27@gmail.com
Cc: peppe.cavallaro@st.com, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch -next] stmmac: unwind properly in stmmac_dvr_probe()
Date: Tue, 21 Dec 2010 10:53:30 -0800 (PST) [thread overview]
Message-ID: <20101221.105330.104073991.davem@davemloft.net> (raw)
In-Reply-To: <20101221073456.GG1936@bicker>
From: Dan Carpenter <error27@gmail.com>
Date: Tue, 21 Dec 2010 10:34:56 +0300
> The original code had a several problems:
> *) It had potential null dereferences of "priv" and "res".
> *) It released the memory region before it was aquired.
> *) It didn't free "ndev" after it was allocated.
> *) It didn't call unregister_netdev() after calling stmmac_probe().
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Nice work, applied.
Thanks Dan.
prev parent reply other threads:[~2010-12-21 18:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-21 7:34 [patch -next] stmmac: unwind properly in stmmac_dvr_probe() Dan Carpenter
2010-12-21 18:53 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101221.105330.104073991.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).