netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: drosenberg@vsecurity.com
Cc: samuel@sortiz.org, netdev@vger.kernel.org, security@kernel.org
Subject: Re: [PATCH] irda: prevent integer underflow in IRLMP_ENUMDEVICES
Date: Thu, 23 Dec 2010 10:09:20 -0800 (PST)	[thread overview]
Message-ID: <20101223.100920.48494288.davem@davemloft.net> (raw)
In-Reply-To: <1293062307.9820.331.camel@dan>

From: Dan Rosenberg <drosenberg@vsecurity.com>
Date: Wed, 22 Dec 2010 18:58:27 -0500

> If the user-provided len is less than the expected offset, the
> IRLMP_ENUMDEVICES getsockopt will do a copy_to_user() with a very large
> size value.  While this isn't be a security issue on x86 because it will
> get caught by the access_ok() check, it may leak large amounts of kernel
> heap on other architectures.  In any event, this patch fixes it.
> 
> Signed-off-by: Dan Rosenberg <drosenberg@vsecurity.com>

Applied, thanks.

      reply	other threads:[~2010-12-23 18:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-22 23:58 [PATCH] irda: prevent integer underflow in IRLMP_ENUMDEVICES Dan Rosenberg
2010-12-23 18:09 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101223.100920.48494288.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=drosenberg@vsecurity.com \
    --cc=netdev@vger.kernel.org \
    --cc=samuel@sortiz.org \
    --cc=security@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).