From: David Miller <davem@davemloft.net>
To: error27@gmail.com
Cc: gregkh@suse.de, linux-usb@vger.kernel.org,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] USB: mcs7830: return negative if auto negotiate fails
Date: Thu, 23 Dec 2010 10:22:16 -0800 (PST) [thread overview]
Message-ID: <20101223.102216.260073588.davem@davemloft.net> (raw)
In-Reply-To: <20101217132542.GL1639@bicker>
From: Dan Carpenter <error27@gmail.com>
Date: Fri, 17 Dec 2010 16:25:43 +0300
> The original code returns 0 on success and 1 on failure. In fact, at
> this point, "ret" is already either zero or a negative error code so
> we can just return it directly.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Indeed, the USBNET ->bind() method, which this return value propagates
to, expects negative return values on error.
Applied, and queued up for -stable, thanks Dan.
prev parent reply other threads:[~2010-12-23 18:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-17 13:25 [patch] USB: mcs7830: return negative if auto negotiate fails Dan Carpenter
2010-12-23 18:22 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101223.102216.260073588.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=error27@gmail.com \
--cc=gregkh@suse.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).