From: David Miller <davem@davemloft.net>
To: jarkao2@gmail.com
Cc: soete.joel@scarlet.be, eric.dumazet@gmail.com,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net-2.6] sundance: Fix oopses with corrupted skb_shared_info
Date: Sat, 25 Dec 2010 19:42:10 -0800 (PST) [thread overview]
Message-ID: <20101225.194210.104056075.davem@davemloft.net> (raw)
In-Reply-To: <20101225151217.GA1994@del.dom.local>
From: Jarek Poplawski <jarkao2@gmail.com>
Date: Sat, 25 Dec 2010 16:12:17 +0100
> [PATCH net-2.6] sundance: Fix oopses with corrupted skb_shared_info
>
> Joel Soete reported oopses at the beginning of pppoe connections since
> v2.6.35. After debugging the bug was found in sundance skb allocation
> and dma mapping code, where skb_reserve() bytes aren't taken into
> account. This is an old bug, only uncovered by some change in 2.6.35.
>
> Initial debugging patch by: Eric Dumazet <eric.dumazet@gmail.com>
>
> Reported-by: Joel Soete <soete.joel@scarlet.be>
> Tested-by: Joel Soete <soete.joel@scarlet.be>
> Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
> Cc: Eric Dumazet <eric.dumazet@gmail.com>
Applied, great work Jarek.
I was auditing ppp_generic.c hoping I'd find something, but
if I had that backtrace I wouldn't have bothered :-)
next prev parent reply other threads:[~2010-12-26 3:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4D0C9BFA.4080003@scarlet.be>
2010-12-22 8:22 ` Help: major pppoe regression since 2.6.35 (panic on first ppp conection)? Andrew Morton
2010-12-22 11:00 ` Jarek Poplawski
2010-12-22 16:00 ` Joel Soete
2010-12-22 16:25 ` Eric Dumazet
2010-12-23 11:02 ` Joel Soete
2010-12-23 12:12 ` Eric Dumazet
2010-12-23 20:25 ` Jarek Poplawski
[not found] ` <4D148271.8030509@scarlet.be>
2010-12-24 15:13 ` Jarek Poplawski
2010-12-25 12:10 ` Jarek Poplawski
2010-12-25 13:51 ` Joel Soete
2010-12-25 15:12 ` [PATCH net-2.6] sundance: Fix oopses with corrupted skb_shared_info Jarek Poplawski
2010-12-25 17:31 ` [PATCH net-2.6] epic100: hamachi: yellowfin: Fix skb allocation size Jarek Poplawski
2010-12-25 17:39 ` [PATCH net-2.6 v2] " Jarek Poplawski
2010-12-26 3:42 ` David Miller
2010-12-26 3:42 ` David Miller [this message]
2010-12-26 11:01 ` [PATCH net-2.6] sundance: Fix oopses with corrupted skb_shared_info Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101225.194210.104056075.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=eric.dumazet@gmail.com \
--cc=jarkao2@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=soete.joel@scarlet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).