From: Dan Carpenter <error27@gmail.com>
To: David Sterba <dsterba@suse.cz>
Cc: mcarlson@broadcom.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Michael Chan <mchan@broadcom.com>
Subject: Re: [PATCH] tg3: fix return value check in tg3_read_vpd()
Date: Mon, 27 Dec 2010 23:19:27 +0300 [thread overview]
Message-ID: <20101227201927.GA6365@bicker> (raw)
In-Reply-To: <1293471094-28976-1-git-send-email-dsterba@suse.cz>
On Mon, Dec 27, 2010 at 06:31:34PM +0100, David Sterba wrote:
> CC: Matt Carlson <mcarlson@broadcom.com>
> CC: Michael Chan <mchan@broadcom.com>
> Signed-off-by: David Sterba <dsterba@suse.cz>
> ---
Your fix is obviously correct, but could you describe the symptoms
in your changelog instead of leaving it blank? In the original code,
negative error values are ignored so we never goto out_not_found. Can
pci_read_vpd() return any errors we care about besides -ENODEV? What I
mean is, did you find this through analysing the code or did it cause a
bug at runtime?
regards,
dan carpenter
next prev parent reply other threads:[~2010-12-27 20:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-27 17:31 [PATCH] tg3: fix return value check in tg3_read_vpd() David Sterba
2010-12-27 20:19 ` Dan Carpenter [this message]
2010-12-29 13:17 ` David Sterba
2010-12-29 13:40 ` [PATCH v2] " David Sterba
2010-12-31 20:31 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101227201927.GA6365@bicker \
--to=error27@gmail.com \
--cc=dsterba@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).